Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 926337 - sys-apps/pciutils-3.11.1 - sysfs.c:456:53: error: call to undeclared function 'basename'
Summary: sys-apps/pciutils-3.11.1 - sysfs.c:456:53: error: call to undeclared function...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/pciutils/pciutils/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: musl-1.2.5
  Show dependency tree
 
Reported: 2024-03-07 09:40 UTC by ernsteiswuerfel
Modified: 2024-07-07 09:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (pciutils-3.11.1:20240307-092518.log,6.96 KB, text/plain)
2024-03-07 09:40 UTC, ernsteiswuerfel 		Details
emerge --info (file_926337.txt,7.42 KB, text/plain)
2024-03-07 09:42 UTC, ernsteiswuerfel 		Details
build.log (3.12.0, amd64) (pciutils-3.12.0:20240513-200212.log,6.95 KB, text/plain)
2024-05-13 20:08 UTC, ernsteiswuerfel 		Details
emerge --info (file_926337.txt,7.65 KB, text/plain)
2024-05-13 20:08 UTC, ernsteiswuerfel 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ernsteiswuerfel archtester 2024-03-07 09:40:59 UTC 
Created attachment 886887 [details]
build.log

[...]
clang -Os -march=x86-64-v2 -pipe -Wall -W -Wno-parentheses -Wstrict-prototypes -Wmissing-prototypes -fPIC -fvisibility=hidden  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o caps.o caps.c
clang -Os -march=x86-64-v2 -pipe -Wall -W -Wno-parentheses -Wstrict-prototypes -Wmissing-prototypes -fPIC -fvisibility=hidden  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -c -o sysfs.o sysfs.c
sysfs.c:456:53: error: call to undeclared function 'basename'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  456 |           pci_set_property(d, PCI_FILL_IOMMU_GROUP, basename(group_link));
      |                                                     ^
sysfs.c:456:53: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'char *' [-Wint-conversion]
  456 |           pci_set_property(d, PCI_FILL_IOMMU_GROUP, basename(group_link));
      |                                                     ^~~~~~~~~~~~~~~~~~~~
./internal.h:131:58: note: passing argument to parameter 'value' here
  131 | char *pci_set_property(struct pci_dev *d, u32 key, char *value);
      |                                                          ^
2 errors generated.
make[1]: *** [<builtin>: sysfs.o] Error 1
make[1]: Leaving directory '/var/tmp/portage/sys-apps/pciutils-3.11.1/work/pciutils-3.11.1-abi_x86_64.amd64/lib'
make: *** [Makefile:79: lib/libpci.so.3.11.1] Error 2
Comment 1 ernsteiswuerfel archtester 2024-03-07 09:42:29 UTC 
Created attachment 886888 [details]
emerge --info
Comment 2 Andreas K. Hüttel archtester gentoo-dev 2024-04-30 15:40:25 UTC 
pciutils-3.12.0 builds and installs fine with musl-1.2.5
Comment 3 ernsteiswuerfel archtester 2024-05-13 20:06:25 UTC 
(In reply to Andreas K. Hüttel from comment #2)
> pciutils-3.12.0 builds and installs fine with musl-1.2.5
Sorry, but 3.12.0 still fails on my system.
Comment 4 ernsteiswuerfel archtester 2024-05-13 20:08:03 UTC 
Created attachment 892888 [details]
build.log (3.12.0, amd64)
Comment 5 ernsteiswuerfel archtester 2024-05-13 20:08:56 UTC 
Created attachment 892889 [details]
emerge --info
Comment 6 ernsteiswuerfel archtester 2024-05-13 21:37:39 UTC 
Opened an upstream issue about it: https://github.com/pciutils/pciutils/issues/182
Comment 7 ernsteiswuerfel archtester 2024-05-30 16:13:31 UTC 
Fixed upstream by: https://github.com/pciutils/pciutils/commit/89cb2ae87236604b0e8ededd0fd7d9425c2d8cb6
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-07 09:21:11 UTC 
Thank you for doing the reports!

commit 70e6b1f5c899438bf42723122462f98986902785
Author: Sam James <sam@gentoo.org>
Date:   Wed Jun 12 06:02:21 2024 +0100

    sys-apps/pciutils: add 3.13.0

    Signed-off-by: Sam James <sam@gentoo.org>