Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 926062 - sys-apps/{s6,s6-rc} strip binaries unconditionally due to upstream Makefiles
Summary: sys-apps/{s6,s6-rc} strip binaries unconditionally due to upstream Makefiles
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Petr Vaněk
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-03 03:42 UTC by Alexis
Modified: 2024-03-03 05:55 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis 2024-03-03 03:42:44 UTC
The Makefiles contain:

    strip: $(ALL_LIBS) $(ALL_BINS)
    ifneq ($(strip $(STATIC_LIBS)),)
        exec $(STRIP) -x -R .note -R .comment $(STATIC_LIBS)
    endif
    ifneq ($(strip $(ALL_BINS)$(SHARED_LIBS)),)
        exec $(STRIP) -R .note -R .comment $(ALL_BINS) $(SHARED_LIBS)
    endif

Other skaware packages might also have the same issue.

Reported based on the following note at https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Backtraces:

> Some packages unfortunately handle stripping by themselves, inside the upstream provided makefiles. This is an error and should be reported. All packages should leave Portage the task of the stripping or simply restrict stripping entirely.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-03 03:58:48 UTC
I don't think the ebuild calls the 'strip' target, and 'strip' doesn't seem to be a dependency of 'all' or 'install'.

I also don't get Portage's QA warning for pre-stripped binaries when installing sys-apps/s6-2.12.0.3.

If you're seeing stripped binaries from the ebuild, please provide more information.

(Also, no need to manually CC maintainers. Bug wranglers do that.)
Comment 2 Alexis 2024-03-03 05:51:17 UTC
Gah. i spent about an hour last night on this, trying to make sure that it wasn't some issue with my setup, before reporting it today - only to find that i now can't reproduce. :-/ i keep trying to be more and more thorough before making bug reports, checking reproducibility etc., and yet ....

Sorry for wasting your time.

(Also, noted re. cc's.)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-03 05:55:43 UTC
I've been there so, so, so many times :)

Don't worry about it.