Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 92586 - sys-apps/grep freebsd portability fixes
Summary: sys-apps/grep freebsd portability fixes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: High minor (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-14 06:02 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-12 10:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch (grep-2.5.1-r7.patch,1.86 KB, patch)
2005-05-14 06:02 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
grep-2.5.1-restrict_arr.patch (grep-2.5.1-restrict_arr.patch,1.04 KB, patch)
2005-05-14 06:03 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
grep-2.5.1-libintl.patch (grep-2.5.1-libintl.patch,1.11 KB, patch)
2005-05-14 06:03 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
grep-2.5.1-libintl.patch (f,2.49 KB, patch)
2005-06-12 15:22 UTC, SpanKY
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-14 06:02:16 UTC
Attached you can find an updated restrict_arr patch which instead of just whitelisting sun, it adds a configure check for features.h file. See bug #80287 to see why that whitelisting was added.

There's also a patch which adds a check for libintl which is needed to complete the linking on systems where libintl is not included in libc.

Finally, the patch for the ebuild adds the two patches, adds an autogen script, and as I was there, I've removed uclibc useflag and used elibc_uclibc to achieve the same thing.

Thanks, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-14 06:02:46 UTC
Created attachment 58864 [details, diff]
Ebuild patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-14 06:03:29 UTC
Created attachment 58865 [details, diff]
grep-2.5.1-restrict_arr.patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-14 06:03:46 UTC
Created attachment 58866 [details, diff]
grep-2.5.1-libintl.patch
Comment 4 SpanKY gentoo-dev 2005-05-14 10:47:37 UTC
are you going to send these fixes upstream ?
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-14 18:50:44 UTC
Not sure about restrict_arr because I don't started with it, I just fixed it to work on G/fbsd...

About libintl, I think I'll try in the next days.
Comment 6 SpanKY gentoo-dev 2005-05-15 12:54:24 UTC
i meant the features.h part of the restrict_arr patch ... the other part with the uclibc define we'll just keep in Gentoo
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-16 04:08:21 UTC
The features.h part is not in plain grep, it was on a gentoo patch...
Comment 8 SpanKY gentoo-dev 2005-06-12 15:22:10 UTC
Created attachment 61125 [details, diff]
grep-2.5.1-libintl.patch

please try this patch
Comment 9 SpanKY gentoo-dev 2005-06-12 15:23:38 UTC
Comment on attachment 58865 [details, diff]
grep-2.5.1-restrict_arr.patch

i updated the patch to simply undefine __restrict_arr and then define it again
as null ... don't need to include features.h in this case
Comment 10 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-06-13 03:03:10 UTC
It re-creates configure after the patch but seems to work fine anyway. 
Comment 11 SpanKY gentoo-dev 2005-06-13 04:55:21 UTC
so drop the configure.in hunk of the patch and try again
Comment 12 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-06-13 05:03:02 UTC
Works, but that's not good anyway because it will have problems if in the 
future configure is regenerated for other patches. 
 
Comment 13 SpanKY gentoo-dev 2005-06-13 16:17:05 UTC
added to 2.5.1-r8