Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925537 - net-misc/remmina-1.4.35: no longer depends on freerdp less than version 3
Summary: net-misc/remmina-1.4.35: no longer depends on freerdp less than version 3
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ben Kohler
URL: https://gitlab.com/Remmina/Remmina/-/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-26 09:22 UTC by Stefan Schmid
Modified: 2024-06-16 11:37 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schmid 2024-02-26 09:22:12 UTC
Since version 1.4.34, this software should also support freerdp from version 3 (see URL). The dependencies in the ebuild should be adjusted accordingly.

Reproducible: Always
Comment 1 Ben Kohler gentoo-dev 2024-02-26 20:46:46 UTC
This is a work in progress, it is planned.  If you want to submit an ebuild patch for testing, I'll take a look.
Comment 2 Nathan Zachary 2024-03-19 19:01:03 UTC
Looking at the ebuild and referencing the following Remmina bug:
https://gitlab.com/Remmina/Remmina/-/issues/3071

it may just require changing the src_configure() `mycmakeargs` from:

-DWITH_FREERDP3=OFF

to:
-DWITH_FREERDP3=ON

If it would be helpful, I can work on testing an ebuild with that change.
Comment 3 Raimund 2024-03-24 15:00:41 UTC
I can confirm this works (for me) without issues. FreeRDP3 is considered stable since December 2023, but a new minor release is coming out every month, so there's still a lot of work going on.
All I can say is remmina 1.4.35 compiled fine with freeRDP-3.4.0 and it also worked for me.
Comment 4 Nathan Zachary 2024-03-25 16:41:50 UTC
I also confirm that building with only that change (and the slot for freerdp) builds and runs without problem.  There's a different issue of it causing tint2 to segfault, but I noticed that happens with the current version of remmina as well, so it isn't related to this change.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-03-25 17:28:33 UTC
Ah, wait, the slot is there in ~arch.
Comment 6 Kyle D. 2024-05-23 20:18:06 UTC
Can confirm swapping -DWITH_FREERDP=3 to ON and setting desired slot to 3 works fine for me. freerdp 2.11.X was failing to build using GCC 14 but freerdp 3.5.1 is alright.
Comment 7 Ben Kohler gentoo-dev 2024-05-24 15:44:22 UTC
commit 61e3c29844fd937718bac1497118e241bb7e9e0b
Author: Ben Kohler <bkohler@gentoo.org>
Date:   Fri May 24 10:36:27 2024 -0500

    net-misc/remmina: revbump for freerdp3 support, X support optional
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>
Comment 8 Ben Kohler gentoo-dev 2024-05-24 15:45:26 UTC
I removed the requirement for X/wayland flags on freerdp, I don't *think* they are needed, but please test and let me know if you have any problems.

Thanks!