Bug 924947 – app-text/poppler-9999: fails to compile (MUSL-CLANG19): implicit instantiation of undefined template 'std::char_traits<unsigned short>'

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description hugegameartgd 2024-02-18 23:04:51 UTC]

Created attachment 885383 [details]
emerge --info

app-text/poppler-9999 fails to compile with libc++-19 (musl/clang/merged-usr)

Steps to Reproduce:
- Compile with `emerge =app-text/poppler-9999::gentoo`

[4/284] /usr/lib/ccache/bin/clang++ -Dpoppler_cpp_EXPORTS -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999 -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/fofi -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/goo -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/poppler -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build/poppler -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build/cpp  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O3 -pipe -march=native -mtune=native -D_FORTIFY_SOURCE=3 -flto=thin -g0 -Wno-implicit-function-declaration -stdlib=libc++ -Wnon-virtual-dtor -Woverloaded-virtual -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT cpp/CMakeFiles/poppler-cpp.dir/poppler-private.cpp.o -MF cpp/CMakeFiles/poppler-cpp.dir/poppler-private.cpp.o.d -o cpp/CMakeFiles/poppler-cpp.dir/poppler-private.cpp.o -c /var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp/poppler-private.cpp
samu: job failed with status 1: /usr/lib/ccache/bin/clang++ -Dpoppler_cpp_EXPORTS -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999 -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/fofi -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/goo -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/poppler -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build/poppler -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp -I/var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build/cpp  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O3 -pipe -march=native -mtune=native -D_FORTIFY_SOURCE=3 -flto=thin -g0 -Wno-implicit-function-declaration -stdlib=libc++ -Wnon-virtual-dtor -Woverloaded-virtual -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT cpp/CMakeFiles/poppler-cpp.dir/poppler-version.cpp.o -MF cpp/CMakeFiles/poppler-cpp.dir/poppler-version.cpp.o.d -o cpp/CMakeFiles/poppler-cpp.dir/poppler-version.cpp.o -c /var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp/poppler-version.cpp
In file included from /var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp/poppler-version.cpp:25:
In file included from /var/tmp/portage/app-text/poppler-9999/work/poppler-9999_build/cpp/poppler-version.h:22:
In file included from /var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp/poppler-global.h:32:
/usr/include/c++/v1/string:746:43: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
  746 |   static_assert((is_same<_CharT, typename traits_type::char_type>::value),
      |                                           ^
/var/tmp/portage/app-text/poppler-9999/work/poppler-9999/cpp/poppler-global.h:101:43: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
  101 | class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned short>
      |                                           ^
/usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
   23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
      |                             ^

[Comment 1 hugegameartgd 2024-02-18 23:05:10 UTC]

Created attachment 885384 [details]
build.log

[Comment 2 Sam James 2024-02-18 23:09:51 UTC]

Please report that upstream. Can't really do much with -9999 build failures which aren't our fault.

[Comment 3 hugegameartgd 2024-02-19 10:08:03 UTC]

Created attachment 885411 [details]
build.log

Same error with app-text/poppler-23.12.0
Should be fixed upstream but also valid for stable versions (Clang >= 19)
https://wiki.gentoo.org/wiki/Modern_C_porting

[Comment 4 hugegameartgd 2024-02-19 10:10:01 UTC]

See https://gitlab.freedesktop.org/poppler/poppler/-/issues/1462

[Comment 5 Sam James 2024-02-19 15:59:39 UTC]

(In reply to hugegameartgd from comment #3)
> Created attachment 885411 [details]
> build.log
> 
> Same error with app-text/poppler-23.12.0
> Should be fixed upstream but also valid for stable versions (Clang >= 19)
> https://wiki.gentoo.org/wiki/Modern_C_porting

C++ isnt C?

[Comment 6 Sam James 2024-02-27 23:23:46 UTC]

Again, not really interested in tracking these things with double 9999s until releases are closer. Especially not so for things w/ active upstreams that get regular releases...