Bug 924443 – app-misc/fastfetch: keyword ~sparc

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Levy Skulk 2024-02-13 21:55:55 UTC]

I've installed yyjson-0.8.0 onto two different Sun Enterprise T5120s with no errors, package was required as a dependency for app-misc/fastfetch which is working as well.

[Comment 1 Eli Schwartz 2024-02-13 23:40:46 UTC]

If the intent is to install fastfetch you should clarify that and add fastfetch to the list of packages you are requesting keywording for.

Have you run the testsuite for both packages?

...

Also note: there's no ~sparc64 keyword, so I assume you meant ~sparc and I prepared the initial package list for yyjson alone.

[Comment 2 Levy Skulk 2024-02-14 15:48:23 UTC]

Hello,

Apologies, keyword should be ~sparc, and the intention was to install fastfetch.

I had thought that keyword requests shouldn't be grouped together but I will do that in the future. 

Also I apologize but I new to contributing and have been reading the guides/documentation as much as I can, but I've not come across information about testing/testsuits. Would you be able to direct me to where I can can catch up on that and I will update the ticket once I have?

[Comment 3 Eli Schwartz 2024-02-14 16:09:14 UTC]

(In reply to Levy Skulk from comment #2)
> I had thought that keyword requests shouldn't be grouped together but I will
> do that in the future. 


Keyword requests can be grouped :) usually what you do is ask for keywording of the package you want (in this case fastfetch) and in the packages field you list any dependencies as well.


> Also I apologize but I new to contributing and have been reading the
> guides/documentation as much as I can, but I've not come across information
> about testing/testsuits. Would you be able to direct me to where I can can
> catch up on that and I will update the ticket once I have?

You could take a look at 

https://wiki.gentoo.org/wiki/Package_testing

The most important thing really is to emerge with FEATURES="test" as that tells emerge to install test dependencies and run the upstream testsuite.

[addCollapseLink(4, 1, 'Toggle comment display'); Comment 4 NATTkA bot 2024-02-14 16:12:16 UTC Comment hidden (obsolete)]

Sanity check failed:

> app-misc/fastfetch-2.8.3
>   depend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     app-misc/ddcutil:=
>     media-gfx/chafa
>   rdepend ~sparc stable profile default/linux/sparc/17.0 (8 total)
>     app-misc/ddcutil:=
>     media-gfx/chafa

[Comment 5 Eli Schwartz 2024-02-14 17:08:27 UTC]

Looks like a couple more packages are needed to get fastfetch running on sparc. Can you confirm whether that functionality is included in the USE flags you tested?

[Comment 6 Levy Skulk 2024-02-14 19:32:01 UTC]

(In reply to Eli Schwartz from comment #5)
> Looks like a couple more packages are needed to get fastfetch running on
> sparc. Can you confirm whether that functionality is included in the USE
> flags you tested?

Could you confirm which packages? 

I initially tested with only the default USE flags, and none are set globally on my systems. I'm currently emerging again with all local flags enabled as the package testing guide suggests.

[Comment 7 Eli Schwartz 2024-02-14 20:10:33 UTC]

ddcutil and chafa are the only ones relevant for fastfetch, I think.

ddcutil has a usb-monitor USE flag that depends on dev-libs/hidapi which would also need keywording for sparc in order to keyword ddcutil itself.

Those three packages should be everything required to get the sanity-check bot ready to proceed with this keywording bug.

[Comment 8 Levy Skulk 2024-02-14 21:57:51 UTC]

Ran some more tests

I did have to accept keywords for both chafa, ddcutil, and hidapi, but after that everything is working great. All three installed properly and FastFetch is working.

Thanks for walking me through this stuff!

[Comment 9 Eli Schwartz 2024-02-14 22:05:37 UTC]

Great, thanks for the confirmation. This should be the final package list, I think.

[Comment 10 Levy Skulk 2024-02-15 19:07:16 UTC]

Thanks, let me know if there is anything else I can/should do

[Comment 11 Eli Schwartz 2024-02-15 19:12:35 UTC]

Nattka has performed its checks and CC'ed the arch team for sparc, so I think we are good to go and just have to wait for them to process this ticket and tell us "all done".

[Comment 12 Rolf Eike Beer 2024-03-01 19:12:44 UTC]

done