Hi, I cannot build remmina (without rdp support) when I have freerdp-3.x installed. I get this message: > -- Configuring done (4.4s) > CMake Error: The following variables are used in this project, but they are set to NOTFOUND. > Please set them or make sure they are set and tested correctly in the CMake files: > FREERDP_CLIENT_LIBRARY > linked by target "remmina-plugin-rdp" in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > FREERDP_INCLUDE_DIR (ADVANCED) > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > used as include directory in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > FREERDP_LIBRARY (ADVANCED) > linked by target "remmina-plugin-rdp" in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > FREERDP_WINPR_LIBRARY > linked by target "remmina-plugin-rdp" in directory /var/tmp/portage/net-misc/remmina-1.4.31-r1/work/Remmina-v1.4.31/plugins/rdp > > CMake Error in plugins/rdp/CMakeLists.txt: > Found relative path while evaluating include directories of > "remmina-plugin-rdp": > > "FREERDP_INCLUDE_DIR-NOTFOUND" FYI: As a workaround, I can uninstall freerdp, then build remmina, then install freerdp-3.x again. I tried unstable remmina-1.4.33-r1 but this is hit by the same issue. The motivation behind using freerdp-3.x are simply the bugfixes in freerdp. I was testeing this on a pure wayland based system.
Please do include the full build.log and emerge --info.
I don't know exactly what is/was going wrong with the build system setup here but it looks like this may be fixed in 1.4.34, can you test? (I have tested, can reproduce your same failure with 1.4.31-r1 and 1.4.33-r1 but not with 1.4.34) Changelog here: https://gitlab.com/Remmina/Remmina/-/releases/v1.4.34 Some highlights: * [freerdp] update to build for stable-3.0 !2554 @akallabeth * Updates Remmina to properly build against FreeRDP 2 and 3 * Simplify FreeRDP detection (let CMake do the magic) * Remove some oboslete/useless code (Bitmap, Glyph, ...) as that is provided by FreeRDP since 2.0 * Allow Remmina to be built without FreeRDP !2558 @myheroyuki
Thank for investigating. I confirm that remmina-1.4.34 fixes the issue. The simple test was: > emerge freerdp:0/3 > emerge =remmina-1.4.31-r1 # BUILD FAILS > emerge =remmina-1.4.34 # BUILD SUCCEEDS IMHO we could can this issue as future stable versions of remmina will fix it.
I hope it is correct for everybody when I close this issue as WONTFIX for the remmina versions I addressed here: 1.4.31-r1 and 1.4.33-r1. The new yet unstable version 1.4.34 fixes it.
Great, happy to hear it. FYI I do plan on wiring up the freerdp-3.x support in remmina at some point as well, so you'll be able to keep USE=rdp on and still keep freerdp-3.
