Bug 922943 – [guru] games-puzzle/blockout-2.5 does not respect CFLAGS

• Status: RESOLVED FIXED
• Product: GURU

[Description Agostino Sarubbo 2024-01-26 07:46:56 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: games-puzzle/blockout-2.5 does not respect CFLAGS.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0017

[Comment 1 Agostino Sarubbo 2024-01-26 07:46:58 UTC]

Created attachment 883145 [details]
build.log

build log and emerge --info

[Comment 2 Abdul 2024-10-20 22:10:32 UTC]

Yeah I looked at the source for this package and it turns out that the makefiles add their own flags and those flags override the ones that are set in make.conf. I am thinking of adding a src_prepare section that adds the user's CFLAGS and CXXFLAGS into the makefiles. Would that be a good solution?

[Comment 3 Abdul 2024-10-21 01:22:32 UTC]

I am working on fixing this issue. This is looking pretty good so far. Will send the patch after I get everything cleaned up and working well.

[Comment 4 Abdul 2024-10-21 02:23:30 UTC]

I fixed it.

[Comment 5 Andrés Becerra Sandoval 2024-10-21 12:15:20 UTC]

Thanks Abdul!