Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 922639 - ninja-utils.eclass: allow overriding ninja implementation from ebuild (e.g. force reference ninja for Fortran)
Summary: ninja-utils.eclass: allow overriding ninja implementation from ebuild (e.g. f...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-21 18:26 UTC by Anna Vyalkova
Modified: 2024-03-28 13:39 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Vyalkova 2024-01-21 18:26:36 UTC
samu can be symlinked to /usr/bin/ninja via app-alternatives but fail to build
a package.
Comment 1 Ionen Wolkens gentoo-dev 2024-01-21 18:45:56 UTC
There's also the NINJA_DEPEND bit to handle unless we want the ebuilds to explicitly set it manually when it's changed.

Rather than set ninja-reference, could alternatively have the eclass handle how to call it too, e.g. NINJA_BACKEND=ninja (or maybe =reference) -> sets NINJA_DEPEND to dev-build/ninja, and set NINJA to call ninja-reference. Default unset would just be whatever app-alternatives is using.

I say NINJA_BACKEND because I always found NINJA too generic to manipulate metadata like it used to, esp. when users been setting it in make.conf but could keep NINJA anyway. On that note, the description for NINJA still has:

    # but other values can be set where NINJA_DEPEND will then be set
    # to a blank variable.

(but that does not happen)

On a side-note, example of a package that need to change this is sci-libs/lapack[1][2]. I'd guess we'll find a few if ever have the tinderboxes test this.

Guess there's possibly that we'll add n2[3] at some point too, may want to keep that there could be a 3rd option in the future when making changes. Haven't tried it and no idea how compatible it is though.

[1] https://github.com/michaelforney/samurai/issues/101
[2] https://github.com/michaelforney/samurai/issues/36
[3] https://github.com/evmar/n2
Comment 2 Lucio Sauer 2024-03-28 13:39:42 UTC
(In reply to Ionen Wolkens from comment #1)
I'd be interested in implementing your proposed changes in ~two weeks from now. Is anyone over at Project:Base working on this already?