Bug 922451 – dev-util/glslang-1.3.275 isn't installing all the headers

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Mike Lothian 2024-01-19 00:37:18 UTC]

I noticed Cemu was complaining that /usr/include/glslang/Include/Types.h was missing

In /usr/include/glslang/Include only the following are available:

glslang_c_interface.h glslang_c_shader_types.h ResourceLimits.h

In the build directory there are:

arrays.h
BaseTypes.h
Common.h
ConstantUnion.h
glslang_c_interface.h
glslang_c_shader_types.h
InfoSink.h
InitializeGlobals.h
intermediate.h
PoolAlloc.h
ResourceLimits.h
ShHandle.h
SpirvIntrinsics.h
Types.h


Reproducible: Always

[Comment 1 Ionen Wolkens 2024-01-19 00:43:40 UTC]

fwiw it seems intentional as far as glslang upstream goes, they have a specific rule for public headers and only install these.

    set(PUBLIC_HEADERS
        Public/ResourceLimits.h
        Public/ShaderLang.h
        Public/resource_limits_c.h
        Include/glslang_c_interface.h
        Include/glslang_c_shader_types.h
        Include/ResourceLimits.h
        MachineIndependent/Versions.h)

    foreach(file ${PUBLIC_HEADERS})
        get_filename_component(dir ${file} DIRECTORY)
        install(FILES ${file} DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/glslang/${dir})
    endforeach()

[Comment 2 Nick Sarnie 2024-01-19 00:44:38 UTC]

https://github.com/KhronosGroup/glslang/issues/3476 seems related

[Comment 3 Mike Lothian 2024-01-19 00:45:50 UTC]

Looks like it was https://github.com/KhronosGroup/glslang/commit/1dcb072cda091180a5b8b03c030bcbe83a54f8e2

[Comment 4 Nick Sarnie 2024-01-19 00:46:56 UTC]

Seems this is an intentional design decision from upstream and downstream software will need to adapt. Not sure there is anything for us to do here. If there is software in gentoo relying on non-existent headers we can update the dependency until the software updates.

[Comment 5 Nick Sarnie 2024-01-19 00:51:27 UTC]

I don't think anything in tree is relying on these now-internal headers, so closing this for now.