Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921325 - media-video/vlc-9999: Failure to compile with libplacebo due to `use of undeclared identifier` errors
Summary: media-video/vlc-9999: Failure to compile with libplacebo due to `use of undec...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL: https://code.videolan.org/videolan/vl...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-04 04:15 UTC by Sandi (Sandy) Vujaković
Modified: 2024-01-22 18:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (vlc-9999:20240104-031817.log,571.24 KB, text/x-log)
2024-01-04 04:15 UTC, Sandi (Sandy) Vujaković
Details
emerge --info (tmp.txt,28.29 KB, text/plain)
2024-01-04 04:17 UTC, Sandi (Sandy) Vujaković
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sandi (Sandy) Vujaković 2024-01-04 04:15:40 UTC
Created attachment 881441 [details]
Build log

When building the live ebuild of VLC with the `libplacebo` USE flag set, the build fails with errors like the following:
```
video_filter/../video_output/opengl/../libplacebo/utils.h:585:32: error: use of undeclared identifier 'pl_filter_function_robidoux'; did you mean 'pl_filter_function_box'?
  585 |     [FILTER_ROBIDOUX]       = &pl_filter_function_robidoux,
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                pl_filter_function_box
```

Going off of the linked VLC bug ticket, it seems that the libplacebo project accidentally removed some deprecated APIs too early. Trying to apply the diff from the libplacebo commit that closed the bug ticket to the libplacebo package did not succeed.

As expected, building VLC without libplacebo support was successful.
Comment 1 Sandi (Sandy) Vujaković 2024-01-04 04:17:34 UTC
Created attachment 881442 [details]
emerge --info
Comment 2 Ionen Wolkens gentoo-dev 2024-01-04 04:55:56 UTC
Since you're using a -9999 package, my recommendation would be to go ahead and use libplacebo-9999, haven't tried it with vlc-9999 but it'll have that fix and I'd assume it works.

I could try to backport the restoration if it was really needed, but I'd rather not if it's only a problem for a live ebuild.

Do hope for a new libplacebo release soon'ish still (it's notably blocking the cache PR in mpv), it's a bit overdue but believe haasn is on break right now.
Comment 3 Sandi (Sandy) Vujaković 2024-01-04 21:40:47 UTC
Yup, libplacebo-9999 works. Thanks for the suggestion!
Comment 4 Ionen Wolkens gentoo-dev 2024-01-22 18:30:51 UTC
For the record, restoring these is still missing the new libplacebo-6.338.2 which is just a minor release done for mpv's cache PR. I assume this may end up waiting for libplacebo-7.