Bug 92104 – xmms-xmmsmplayer crashes xmms when determining whether a file is valid for it

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jon Dowdall 2005-05-10 05:14:10 UTC]

Determining the input pluging to use for certain files a SIGSEGV is raised killing xmms.

The error is was introduced by the fix for bug #81690 specifically in the mplayer_is_our_file function in xmmsmplayer.c if the mplayer_current_cfg->exts pointer had not been set the following line causes a SIGSEGV signal to be raised killing xmms:

char *exts = strdup(mplayer_current_cfg->exts);

I've changed the code to read:

	char *exts;
	
	if (!mplayer_current_cfg->exts)
	{
		fprintf(stderr, "mplayer_current_cfg->exts == NULL!\n");
		return FALSE;
	}
	
	exts = strdup(mplayer_current_cfg->exts);

and removed the seemingly unnecessary strcpy, this has fixed my problem.

I've not tracked down why mplayer_current_cfg->exts is not set but even so the code should not kill xmms in these circumstances.

Reproducible: Always
Steps to Reproduce:
1. With xmms-xmmsmplayer enabled
2. Attempt to load an ogg file
3.
Actual Results:  
xmms crashes with sigsegv

Expected Results:  
ogg file loaded

[Comment 1 Martijn Koster 2005-06-27 15:52:15 UTC]

I saw the same thing, trying to listen to streams from streamtuner.  
Described fix works for me. 
 

[Comment 2 Luis Medinas (RETIRED) 2005-11-03 15:17:46 UTC]

can you please attach a patch against it ?

[Comment 3 Jon Dowdall 2005-11-12 04:42:46 UTC]

Created attachment 72735 [details, diff]
Patch as descibed in the original description

As requested, the attached patch is based on the original description.

[Comment 4 Luis Medinas (RETIRED) 2006-01-11 17:27:11 UTC]

Thanks for the patch. It's in portage.