Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 92098 - Add custom-cflags USE flag to xine-lib
Summary: Add custom-cflags USE flag to xine-lib
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-10 03:02 UTC by Giacomo Perale
Modified: 2005-05-10 06:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xine-lib-1.0.1-r1-ebuild-add-custom-cflags.patch (xine-lib-1.0.1-r1-ebuild-add-custom-cflags.patch,957 bytes, patch)
2005-05-10 03:31 UTC, Giacomo Perale
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Giacomo Perale 2005-05-10 03:02:43 UTC
Recent mplayer-1.0_pre7.ebuild includes a new USE flag, custom-cflags, that allow the user to choose if use the Gentoo system CFLAGS or the default mplayer CFLAGS. This is useful because mplayer developers don't accept bug reports for mplayer compiled with different CFLAGS and the default ones are more extreme (-O4) than sane CFLAGS a normal user could want.
Even though xine developers aren't so severe about this question, xine-lib provide their CFLAGS and I'd like to be able to choose the set of CFLAGS as well.
Comment 1 Giacomo Perale 2005-05-10 03:31:04 UTC
Created attachment 58555 [details, diff]
xine-lib-1.0.1-r1-ebuild-add-custom-cflags.patch

patch to add custom-cflags USE flag to xine-lib-1.0.1-r1.ebuild
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-05-10 05:04:32 UTC
I don't like this actually.
Mainly because xine-lib doesn't ignore user-defined cflags but just cut them down to "usable" ones.

So this is not going to be added, sorry.
Comment 3 Giacomo Perale 2005-05-10 05:42:57 UTC
to the contrary

for example, an user-defined -O2 override xine-defined -O3
Comment 4 Luca Barbato gentoo-dev 2005-05-10 06:14:51 UTC
Keep in mind that I'm defaulting to the mplayer factory cflags since are working correctly and most bugs I have been forced to close were about cflags issues...