Bug 920835 – dev-lang/ghc-9.2.8 implicit function declaration in configure logs: exit

• Status: UNCONFIRMED
• Product: Gentoo Linux

[Description Attila Tóth 2023-12-27 23:09:01 UTC]

* QA Notice: Found the following implicit function declarations in configure logs:
 *   /var/tmp/portage/dev-lang/ghc-9.2.8/work/ghc-9.2.8/config.log:5887 - exit
 * Check that no features were accidentally disabled.
 * See https://wiki.gentoo.org/wiki/Modern_C_porting.


Reproducible: Always




Including stdlib.h in the culprit section solves the notice:
diff -urNp ghc-9.2.8-orig/configure ghc-9.2.8-dwok/configure
--- ghc-9.2.8-orig/configure    2023-05-26 12:58:09.000000000 +0200
+++ ghc-9.2.8-dwok/configure    2023-12-27 10:39:41.036001901 +0100
@@ -16673,6 +16673,7 @@ else $as_nop
 struct nlist xYzzY1[] = {{"xYzzY1", 0},{0}};
 struct nlist xYzzY2[] = {{"_xYzzY2", 0},{0}};
 #endif
+#include <stdlib.h>

 int main(argc, argv)
 int argc;
diff -urNp ghc-9.2.8-orig/m4/fp_leading_underscore.m4 ghc-9.2.8-dwok/m4/fp_leading_underscore.m4
--- ghc-9.2.8-orig/m4/fp_leading_underscore.m4  2023-05-26 01:03:00.000000000 +0200
+++ ghc-9.2.8-dwok/m4/fp_leading_underscore.m4  2023-12-27 10:40:15.655892509 +0100
@@ -31,6 +31,7 @@ case $TargetPlatform in
 struct nlist xYzzY1[] = {{"xYzzY1", 0},{0}};
 struct nlist xYzzY2[] = {{"_xYzzY2", 0},{0}};
 #endif
+#include <stdlib.h>

 int main(argc, argv)
 int argc;

[Comment 1 Attila Tóth 2023-12-27 23:09:40 UTC]

Created attachment 880785 [details, diff]
ghc-9.2.8_configure-leading-underscore-check-missing-include.patch

Proposed patch solves the notice.