Bug 92081 – urwid 0.8.7.2 - new patch for input handling restores 'down' key functionality

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Daniel Holth 2005-05-09 23:56:42 UTC]

updated patch fixes problem

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
'down' was incorrectly represented as '[down'

Expected Results:  
'down' should be called 'down' without an opening bracket

[Comment 1 Daniel Holth 2005-05-09 23:58:43 UTC]

Created attachment 58541 [details, diff]
revised patch fixes down arrow

http://excess.org/urwid/patch-0.8.7.2.diff

[Comment 2 Rob Cakebread (RETIRED) 2005-05-10 08:34:45 UTC]

Daniel, is this a duplicate of bug #91338? I added the patch, after noticing it (the ebuild in the bug didn't use the patch so I missed it at first)

[Comment 3 Daniel Holth 2005-05-10 09:37:32 UTC]

I hope I wasn't too unclear. In the other bug I tried to say the other patch was broken.
The previous patch 0.8.7.1 that was put in CVS fixes 'esc' key handling but breaks 'down' key handling.
The new patch 0.8.7.2 fixes the down key error. This is the difference between the old patch and the patch attached to this bug.

13c13
< +     ('[A','up'),('[B','down'),('[C','right'),('[D','left'),
---
> +     ('[A','up'),('[B','[down'),('[C','right'),('[D','left'),

[Comment 4 Daniel Holth 2005-05-10 09:40:32 UTC]

The diff between two patches is backwards. Simply, the patch attached to this bug is slightly different and much more correct. It replaces the other urwid patch.

[Comment 5 Rob Cakebread (RETIRED) 2005-05-15 10:27:38 UTC]

Thanks Daniel, fixed in CVS.