Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 920535 - media-gfx/gimp-9999 Installs include files depending on non-installed headers
Summary: media-gfx/gimp-9999 Installs include files depending on non-installed headers
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Sergey Torokhov
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-22 15:05 UTC by Kirin Etheridge
Modified: 2024-02-28 06:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info for media-gfx/gimp (gimp-emergeinfo.txt,26.16 KB, text/plain)
2023-12-22 15:05 UTC, Kirin Etheridge
Details
patch adding a few libgimpbase headers to be installed (gimp-9999-missing-headers.patch,546 bytes, patch)
2023-12-23 00:20 UTC, Kirin Etheridge
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kirin Etheridge 2023-12-22 15:05:03 UTC
Created attachment 880234 [details]
emerge --info for media-gfx/gimp

I recently found an ebuild for "media-gfx/gmic" in the stefantalpalaru overlay. This ebuild currently is only for GIMP 2.10, and I use GIMP 2.99. I modified the ebuild slightly to respect GIMP 3 usage, but it is impossible to build, as it depends on a file called "gimpchoice.h".

This file is called by `/usr/include/gimp-3.0/libgimpbase/gimpbase.h`, which includes it on line 27: "#include <libgimpbase/gimpchoice.h>".
Therefore, I am filing this bug here and not on the ebuild's overlay, as it seems like the GIMP package from the gentoo repository doesn't install a file it should.
This file exists in GIMP's source code, under https://gitlab.gnome.org/GNOME/gimp/-/blob/master/libgimpbase/gimpchoice.h, but isn't installed on the system.

This issue does not appear on media-gfx/gimp-2.10.36-r1, as libgimpbase/gimpbase.h does not include gimpchoice.h.

Since I use the LLVM 23.0 profile with LTO enabled, I tried rebuilding without LTO, and also with USE="test doc", where neither fix the issue.

My emerge --info for media-gfx/gimp is attached.
Comment 1 Alfred Wingate 2023-12-22 15:19:25 UTC
Looks like it was reported but the issue wasn't noticed and was closed as NOTABUG. It appears to be case a where upstream forgot to add it to be installed when adding it.

https://gitlab.gnome.org/GNOME/gimp/-/commit/7e6b01a4e5257030f7e4ceac67b44564759cd6a1
https://gitlab.gnome.org/GNOME/gimp/-/commit/4163a29af3457807730bc8e6b8616f6fad636fd1
https://gitlab.gnome.org/GNOME/gimp/-/issues/10132
Comment 2 Kirin Etheridge 2023-12-23 00:19:54 UTC
A simple patch to include that header file in "libgimpbase/meson.build" fixes this issue until upstream figures it out, perhaps it should be reported there again more precisely.

I will attach the patch I made, which adds a few missing headers.
Note that I didn't add anything to libgimpbase/meson.build, as I couldn't get the program to compile after the changes, at least on my system.
Comment 3 Kirin Etheridge 2023-12-23 00:20:29 UTC
Created attachment 880248 [details, diff]
patch adding a few libgimpbase headers to be installed
Comment 4 Alfred Wingate 2023-12-24 09:12:22 UTC
Currently making a patch for gimp that I hope they would accept.

Are gimpcompatenums.h and gimpwire.h required to be installed for you? They don't appear to have the same issue where they are included in other installed headers. I only saw one other header that had this issue and that was libgimpwidgets/gimplabelstringwidget.h
Comment 5 Kirin Etheridge 2023-12-25 00:11:22 UTC
(In reply to Alfred Wingate from comment #4)
> Currently making a patch for gimp that I hope they would accept.
> 
> Are gimpcompatenums.h and gimpwire.h required to be installed for you? They
> don't appear to have the same issue where they are included in other
> installed headers. I only saw one other header that had this issue and that
> was libgimpwidgets/gimplabelstringwidget.h

Oh, actually, no they aren't. It's only gimpchoice.h which matters for me. I thought I'd include those as well to get a more complete install, in case others would need them, but I personally do not.
Comment 6 Alfred Wingate 2024-02-28 06:13:33 UTC
Fix merged upstream