Bug 91977 – new version of eject

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Nathaniel McCallum (RETIRED) 2005-05-08 23:35:52 UTC]

New version of eject including a bunch of patches from ubuntu, including:
   - a new version of the finddev patch (adds documentation)
   - pumount support (for Utopia; blocks #91928) 
   - several fixes for remote situations
   - check malloc return value for NULL

Reproducible: Always
Steps to Reproduce:

[Comment 1 Nathaniel McCallum (RETIRED) 2005-05-08 23:37:28 UTC]

Created attachment 58442 [details, diff]
make sure fd's are closed correctly

[Comment 2 Nathaniel McCallum (RETIRED) 2005-05-08 23:38:04 UTC]

Created attachment 58443 [details, diff]
make sure DEFAULTDEVICE starts with "/dev/"

[Comment 3 Nathaniel McCallum (RETIRED) 2005-05-08 23:38:34 UTC]

Created attachment 58444 [details, diff]
new version of finddev (includes documentation)

[Comment 4 Nathaniel McCallum (RETIRED) 2005-05-08 23:38:57 UTC]

Created attachment 58445 [details, diff]
make sure we can read fstab

[Comment 5 Nathaniel McCallum (RETIRED) 2005-05-08 23:39:29 UTC]

Created attachment 58446 [details, diff]
check the return value of malloc for NULL

[Comment 6 Nathaniel McCallum (RETIRED) 2005-05-08 23:39:58 UTC]

Created attachment 58447 [details, diff]
adds a don't unmount option

[Comment 7 Nathaniel McCallum (RETIRED) 2005-05-08 23:40:27 UTC]

Created attachment 58448 [details, diff]
adds pumount support (project utopia)

[Comment 8 Nathaniel McCallum (RETIRED) 2005-05-08 23:40:57 UTC]

Created attachment 58449 [details, diff]
make sure we have a proper regex

[Comment 9 Nathaniel McCallum (RETIRED) 2005-05-08 23:41:42 UTC]

Created attachment 58450 [details]
new ebuild

[Comment 10 Jakub Moc (RETIRED) 2005-05-08 23:55:25 UTC]

Would you like to have a look at Bug 62612 as well? :-)

[Comment 11 Nathaniel McCallum (RETIRED) 2005-05-09 00:08:18 UTC]

sure, you can assign it to me if you like, but I'd like to put it in a revision on its own to get more testing.  All the patches I've put here are fairly well tested.

[Comment 12 SpanKY 2005-05-09 00:17:44 UTC]

fedora has a patch or two not included here ...

[Comment 13 Jakub Moc (RETIRED) 2005-05-09 00:51:47 UTC]

Comment #11: As you wish, assigned #62612 to you. If you

[Comment 14 Jakub Moc (RETIRED) 2005-05-09 00:51:47 UTC]

Comment #11: As you wish, assigned #62612 to you. If you´d like to maintain this ebuild, then you could add yourself to metadata.xml. 

[Comment 15 SpanKY 2005-05-20 20:30:55 UTC]

some notes ...

- the close patch is pretty stupid/pointless
- the malloc check is incomplete ... it's not the only malloc in eject.c
- the regcomp check is incomplete ... it's not the only regcomp in eject.c
- what's the point of the pumount patch ?

added all but the pumount patch to eject-2.0.13-r2 after cleaning many of them up

[Comment 16 Nathaniel McCallum (RETIRED) 2005-05-20 20:38:22 UTC]

pmount (and pumount) are policy wrappers around mount for removeable devices
that aren't in fstab.  Desktop programs use eject (ie. gnome-vfs).  Lets say in
this case you plug in a usb zip drive.  gnome-vfs uses pmount to mount it, then
the user wants to eject it.  The user chooses eject in nautilus, which (through
gnome-vfs) calls eject.  When eject tries to umount the device, it will fail, so
eject will be broken.  The pumount tries at runtime to run pumount before
umount.  Nothing breaks if pumount isn't installed or fails (we don't check the
exit status).

[Comment 17 SpanKY 2005-05-20 22:58:44 UTC]

added to 2.0.13-r2