Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91883 - fluxbox guide improvements
Summary: fluxbox guide improvements
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs-user
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Docs Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-08 06:51 UTC by Alin Dobre (RETIRED)
Modified: 2005-05-10 09:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fluxbox-config_fbrun.patch (fluxbox-config_fbrun.patch,1.98 KB, patch)
2005-05-08 06:53 UTC, Alin Dobre (RETIRED)
Details | Diff
fluxbox-config_menu.patch (fluxbox-config_menu.patch,2.34 KB, patch)
2005-05-09 12:41 UTC, Alin Dobre (RETIRED)
Details | Diff
fluxbox-config_menu.txt (fluxbox-config_menu.txt,1.88 KB, text/plain)
2005-05-09 12:43 UTC, Alin Dobre (RETIRED)
Details
fluxbox-config_megapatch.xml.diff (fluxbox-config_megapatch.xml.diff,8.25 KB, patch)
2005-05-09 17:52 UTC, Jonathan Smith (RETIRED)
Details | Diff
fluxbox-config_megapatch.xml.diff (fluxbox-config_megapatch.xml.diff,8.25 KB, patch)
2005-05-10 07:43 UTC, Jonathan Smith (RETIRED)
Details | Diff
fluxbox-config_megapatch.xml.diff.patch (fluxbox-config_megapatch.xml.diff.patch,4.01 KB, text/plain)
2005-05-10 08:23 UTC, Camille Huot (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alin Dobre (RETIRED) gentoo-dev 2005-05-08 06:51:26 UTC
Attaching a proposed patch that will add information about fbrun in the fluxbox-config.xml guide.
Comment 1 Alin Dobre (RETIRED) gentoo-dev 2005-05-08 06:53:24 UTC
Created attachment 58351 [details, diff]
fluxbox-config_fbrun.patch

well, here it is.
smithj, please take a look and, if everyone is ok with this, gimme a green
light to commit it.
Comment 2 Alin Dobre (RETIRED) gentoo-dev 2005-05-08 07:13:57 UTC
If you wonder, I have intentionally omitted the date and version tags, as I consider that this is the commiter's job, not the patch-proposer's one.
Comment 3 Jonathan Smith (RETIRED) gentoo-dev 2005-05-08 17:50:19 UTC
i don't have to give you the green. you are the dev, not me ;-)

however, there are a few things i would change, for instance, the location of this section. gimme a day or so and i will think about it (assuming you want my input)
Comment 4 Alin Dobre (RETIRED) gentoo-dev 2005-05-08 21:24:23 UTC
I put the section there, because the next ones (system monitor, desktop icons, etc) were based on external applications and this one was a fluxbox internal. Anyway, I'll let you think about the section location.
Comment 5 Alin Dobre (RETIRED) gentoo-dev 2005-05-09 12:39:58 UTC
Alrighty, here is the patch to current CVS doc and a separate file which contain only the 'Fluxbox menu' section (without the + chars at the beginning of the line, added by diff). Use either of them.
Of course, any feedback appreciated.
Comment 6 Alin Dobre (RETIRED) gentoo-dev 2005-05-09 12:41:25 UTC
Created attachment 58509 [details, diff]
fluxbox-config_menu.patch

here's the patch.
Comment 7 Alin Dobre (RETIRED) gentoo-dev 2005-05-09 12:43:14 UTC
Created attachment 58511 [details]
fluxbox-config_menu.txt

and here's the section, if you want to add it in another place in the doc.
Comment 8 Jonathan Smith (RETIRED) gentoo-dev 2005-05-09 17:52:30 UTC
Created attachment 58533 [details, diff]
fluxbox-config_megapatch.xml.diff

consider all the other patches obsolete by this one. i can't mark them that
way, but all of the previous patches are slightly modified and included in this
diff.

alin, i changed the wording in a few places not so much because it was wrong,
but to make it consistant with the rest of the guide. other than that, very
nice patches :-) thank you very much

version bump from 1.0.4 to 1.1.0 due to relatively large revisions

added alin as an editor due to his work on this doc and his discussion with me
about it in irc.

this patch includes editing the menu file by hand, file managers in flux,
picture viewers in flux, fbrun, and menu/key shortcuts for the above.
Comment 9 Jonathan Smith (RETIRED) gentoo-dev 2005-05-09 17:55:24 UTC
oh, you can also view the rendered html of the new doc at http://neverland.ncssm.edu/~smithj/gentoo/fluxbox-config.html
Comment 10 Alin Dobre (RETIRED) gentoo-dev 2005-05-09 22:25:09 UTC
I have marked all the other attachments as obsolete.
Swift, can you take a look at the patch and give me a green light to commit it (or commit it yourself, if ok)?
Comment 11 Shyam Mani (RETIRED) gentoo-dev 2005-05-10 07:22:56 UTC
I took a look at the online version, guess we can commit these changes.

Good work Jonathan & Alin :)
Comment 12 Jonathan Smith (RETIRED) gentoo-dev 2005-05-10 07:32:43 UTC
alin, i think we are ready to commit. one thing, however. in your section (on fbrun), replace RUN with Run... per request of some folks in #gentoo-doc

i could create a patch, but i'm not sure that its needed. just apply the megapatch and replace that if you think its necessary.

good work all
Comment 13 Alin Dobre (RETIRED) gentoo-dev 2005-05-10 07:35:14 UTC
this evening, after i'll get home, i'll apply the patch and s/RUN/Run/g, then xmllint --valid --noout fluxbox-config.xml && cvs ci
;-)
Comment 14 Jonathan Smith (RETIRED) gentoo-dev 2005-05-10 07:43:33 UTC
Created attachment 58564 [details, diff]
fluxbox-config_megapatch.xml.diff

this fixes a few tpyos and the RUN thingy. just apply it and commit
Comment 15 Camille Huot (RETIRED) gentoo-dev 2005-05-10 08:23:12 UTC
Created attachment 58574 [details]
fluxbox-config_megapatch.xml.diff.patch

Please consider this patch to the patch (!).
There should be one hunk failed when you patch, just ignore.
Comment 16 Alin Dobre (RETIRED) gentoo-dev 2005-05-10 09:10:32 UTC
Checked and commited. Thank you all!