Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91773 - Kphone 4.1.1 is out for some time
Summary: Kphone 4.1.1 is out for some time
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo KDE team
URL: http://www.wirlab.net/kphone/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-07 01:41 UTC by Antti Mäkelä
Modified: 2005-07-04 00:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Mäkelä 2005-05-07 01:41:43 UTC
Kphone 4.1.1 is out. For some reason, just copying 4.1.0 ebuild does not work at least for my configuration. Any ideas how to fix that so we can get this into portage tree?

Oh, and I removed the Makefiles.patch that was still present in 4.1.0 ebuild because the DESTDIR issue was addressed..

make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/ilbc'
make[1]: Entering directory `/var/tmp/portage/kphone-4.1.1/work/kphone/kphone'
make[1]: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
i686-pc-linux-gnu-g++ -I/usr/qt/3/include -Wall -O3 -I. -I../gsm -I../ilbc -I../dissipate2 -DHAVE_CONFIG_H -DSHARE_DIR=\"/usr/share/apps/kphone\" -DPO_DIR=\"/usr/share/kphone/translations//\"  -c -o dspoutalsa.o dspoutalsa.cpp
dspoutalsa.cpp: In member function `virtual bool DspOutAlsa::writeBuffer()':
dspoutalsa.cpp:192: error: ISO C++ forbids cast to non-reference type used as lvalue
make[1]: *** [dspoutalsa.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/kphone'
make: *** [all] Error 2
>>> Test phase [not enabled]: net-misc/kphone-4.1.1

>>> Install kphone-4.1.1 into /var/tmp/portage/kphone-4.1.1/image/ category net-misc
make[1]: Entering directory `/var/tmp/portage/kphone-4.1.1/work/kphone/po'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/po'
make[1]: Entering directory `/var/tmp/portage/kphone-4.1.1/work/kphone/dissipate2'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/dissipate2'
make[1]: Entering directory `/var/tmp/portage/kphone-4.1.1/work/kphone/gsm'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/gsm'
make[1]: Entering directory `/var/tmp/portage/kphone-4.1.1/work/kphone/ilbc'
make[1]: Nothing to be done for `all'.
make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/ilbc'
make[1]: Entering directory `/var/tmp/portage/kphone-4.1.1/work/kphone/kphone'
i686-pc-linux-gnu-g++ -I/usr/qt/3/include -Wall -O3 -I. -I../gsm -I../ilbc -I../dissipate2 -DHAVE_CONFIG_H -DSHARE_DIR=\"/usr/share/apps/kphone\" -DPO_DIR=\"/usr/share/kphone/translations//\"  -c -o dspoutalsa.o dspoutalsa.cpp
dspoutalsa.cpp: In member function `virtual bool DspOutAlsa::writeBuffer()':
dspoutalsa.cpp:192: error: ISO C++ forbids cast to non-reference type used as lvalue
make[1]: *** [dspoutalsa.o] Error 1
make[1]: Leaving directory `/var/tmp/portage/kphone-4.1.1/work/kphone/kphone'
make: *** [all] Error 2

!!! ERROR: net-misc/kphone-4.1.1 failed.
!!! Function kde_src_install, Line 191, Exitcode 2
!!! died running make install, kde_src_install:make
!!! If you need support, post the topmost build error, NOT this status message.
Comment 1 Thomas Fischer 2005-05-07 17:15:44 UTC
I tried to reproduce this bug by copying the official 4.1.0 ebuild into my local portage tree as 4.1.1 (no patches applied). Kphone compiled and runs successfully. Although I'm using the alsa use flage, this bug does not occur on my system.
Maybe Antti's system cannot handle the int8_t* cast?

  (int8_t*) buf += rc*4;

Suggestion: Try to compile kphone 4.1.1 by hand (into /usr/local) or disable alsa support and see what happens then.
Comment 2 Antti Mäkelä 2005-05-08 11:33:26 UTC
Does not work for me. I tried manually, also the same error. Adjusting CFLAGS to safer (from -march=pentium2, -O3) did not help either..

GCC is 3.4.3. I wonder if it works with 3.3 only?

Also trying without alsa support (leaving --enable-alsa out of configure) does not work for me.

My ebuild is just the 4.1.0 ebuild with the makefilepatch removed.

# Copyright 1999-2005 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/net-misc/kphone/kphone-4.1.0.ebuild,v 1.3 200
5/01/18 19:05:51 gustavoz Exp $

inherit eutils kde

DESCRIPTION="A SIP user agent for Linux, with which you can initiate VoIP connec
tions over the Internet."
HOMEPAGE="http://www.wirlab.net/kphone/index.html"
SRC_URI="http://www.wirlab.net/kphone/${P}.tar.gz"

KEYWORDS="x86 ~amd64 sparc ~ppc"
LICENSE="GPL-2"

IUSE="alsa jack"
SLOT="0"

S=${WORKDIR}/kphone

DEPEND="alsa? ( media-libs/alsa-lib virtual/alsa )
        jack? ( media-sound/jack-audio-connection-kit )"

need-kde 3

src_unpack() {
        unpack ${A}

        cd ${S}
#       epatch ${FILESDIR}/${P}-Makefiles.patch
}


src_compile(){
        # Fix for our kde location
        myconf="$myconf --with-extra-libs=$KDEDIR/lib --prefix=/usr `use_enable
alsa` `use_enable jack`"
        econf ${myconf} || die "econf failed"
        emake
}
Comment 3 Thorsten Becker 2005-05-10 09:23:45 UTC
Renaming /commenting out the makefile patch worked perfectly for me. Even with alsa use-flag.
I have alsa-driver from kernel (vanilla 2.6.11.7) and alsa-lib-1.0.8 installed. Perhaps it fails with another alsa-lib-version?
Comment 4 Antti Mäkelä 2005-05-10 14:18:38 UTC
Nope, I have the same alsa-lib version (1.08). I'm using ck-sources though, but that shouldn't matter because linux headers are taken from linux-headers package anyway.

However, digging through the kphone CVS shows something:

http://cvs.wirlab.net/cgi-bin/viewcvs.cgi/kphone/kphone/dspoutalsa.cpp

http://cvs.wirlab.net/cgi-bin/viewcvs.cgi/kphone/kphone/dspoutalsa.cpp?r1=1.2&r2=1.3

I guess that patch needs to be included if compiling with gcc 3.4. I'll try it out and if it works I'll make a new ebuild that includes the patch (provided that kphone 4.1.2 does not get released like tomorrow...)

Comment 5 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-27 03:35:29 UTC
Committed, including the gcc-3.4 patch. Thanks. 
 
I also changed the ebuild to reflect the fact that kphone is not a KDE app, 
but a Qt-only app. 
 
Comment 6 Antti Mäkelä 2005-05-27 03:41:46 UTC
Thanks, I had forgotten about this for a while :)
Comment 7 Florian Loitsch 2005-07-02 09:57:01 UTC
Are you sure the gcc-3.4 patch is correct? 
the original code modifies 'buf', while the new one only modifies the 
temporary variable 'buff'. (I might be wrong, as I haven't tested it directly 
on kphone). 
Comment 8 Antti Mäkelä 2005-07-04 00:46:29 UTC
It is correct, for it compiles with the patch...