Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 916975 - x11-apps/xcur2png: implicit int
Summary: x11-apps/xcur2png: implicit int
Status: RESOLVED INVALID
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: tea
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-06 20:58 UTC by Pascal Jäger
Modified: 2023-11-20 11:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (xcur2png-build.log,6.39 KB, text/x-log)
2023-11-06 20:58 UTC, Pascal Jäger
Details
emerge info (emerge-info,6.88 KB, text/plain)
2023-11-06 20:59 UTC, Pascal Jäger
Details
emerge-pqv (emereg-pqv,51 bytes, text/plain)
2023-11-06 21:00 UTC, Pascal Jäger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Jäger 2023-11-06 20:58:16 UTC
xcur2png.c:674:10: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
  extern dry_run;

Does not work with newer clang and default settings. 

Upstream has a PR open for a year now that fixes this. Maybe we want to include that as a patch in the ebuild.
Comment 1 Pascal Jäger 2023-11-06 20:58:34 UTC
Created attachment 874187 [details]
build log
Comment 2 Pascal Jäger 2023-11-06 20:59:43 UTC
Created attachment 874188 [details]
emerge info
Comment 3 Pascal Jäger 2023-11-06 21:00:35 UTC
Created attachment 874189 [details]
emerge-pqv
Comment 4 tea 2023-11-06 22:00:28 UTC
0.7.1-r1 should deal with that by adding `-std=gnu89` to CFLAGS¹ and it works for me with clang 17.0.3.

where does the `-Werror=implicit-int` in your build log come from, did you add it to your CFLAGS? maybe via a bashrc hook?

i don't think it is necessary to fix it downstream since it doesn't seem to cause runtime issues and the `-std=gnu89` switch will probably keep being supported for as long as this program is useful.

¹ see <https://bugs.gentoo.org/916457>
Comment 5 tea 2023-11-20 11:59:14 UTC
closing since it compiles without -Werror and i got no answer for 2 weeks. feel free to reopen if you disagree.