I started seeing crashes in www-client/chromium starting at 116.0.5845.140, seemingly related to the change in Chromium commit 0ce6af60daa74a14cab3ebe34bc3bff880122467, where a code path calls VideoFrame::BytesPerElement(VideoPixelFormat, size_t) with an enumerator value that falls through to the NOTREACHED_NORETURN and crashes. Previously this code path logged and returned 0. Somehow VideoFrame::BytesPerElement(VideoPixelFormat, size_t) is being called with format == PIXEL_FORMAT_UNKNOWN or some other value that is not one of the enumerated values handled by the switch statement. This causes some web pages to crash ("Aw, Snap!"), with the following log message emitted to stderr: [20130:10:0915/233802.580525:FATAL:video_frame.cc(1109)] NOTREACHED hit. I filed a bug upstream at https://bugs.chromium.org/p/chromium/issues/detail?id=1495287 but it was tentatively closed as WONTFIX since I can't reproduce the issue on my system using www-client/google-chrome-stable. So, it would seem that Gentoo is doing something funky with www-client/chromium that is breaking HTML5 video on my system. I can make it survive (i.e., not crash) by reverting that change in video_frame.cc, but obviously that's only papering over the problem. # emerge -pqv www-client/chromium [ebuild R ] www-client/chromium-118.0.5993.88 USE="X cups proprietary-codecs qt5 system-harfbuzz system-icu system-png system-zstd vaapi -custom-cflags -debug -gtk4 -hangouts (-headless) -kerberos (-libcxx) (-lto) -official -pax-kernel (-pgo) -pulseaudio -qt6 -screencast (-selinux) -wayland -widevine" L10N="-af -am -ar -bg -bn -ca -cs -da -de -el -en-GB -es -es-419 -et -fa -fi -fil -fr -gu -he -hi -hr -hu -id -it -ja -kn -ko -lt -lv -ml -mr -ms -nb -nl -pl -pt-BR -pt-PT -ro -ru -sk -sl -sr -sv -sw -ta -te -th -tr -uk -ur -vi -zh-CN -zh-TW" # emerge --info www-client/chromium Portage 3.0.54 (python 3.12.0-final-0, default/linux/amd64/23.0/desktop/plasma, gcc-13, glibc-2.38-r6, 6.1.53-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-6.1.53-gentoo-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q6600_@_2.40GHz-with-glibc2.38 KiB Mem: 8148460 total, 883852 free KiB Swap: 8388604 total, 4984020 free Timestamp of repository gentoo: Sat, 28 Oct 2023 10:45:01 +0000 Head commit of repository gentoo: 3270a41702b0af68989b4da69e6bb57c149f5acd Timestamp of repository 4nykey: Sat, 28 Oct 2023 08:46:40 +0000 Head commit of repository 4nykey: 09a97f533cf88dcfc3c799e9bd3c5172741c274c Timestamp of repository bitcoin: Thu, 26 Oct 2023 22:03:31 +0000 Head commit of repository bitcoin: 0adee07f48da1ef8feebef8b97b4e09ed7bced69 Timestamp of repository eigenlay: Thu, 26 Oct 2023 22:03:34 +0000 Head commit of repository eigenlay: 5175ed84c64d47f162d08fa5aa8ea190e6981845 Timestamp of repository gentoo-bootstrap: Thu, 26 Oct 2023 22:03:55 +0000 Head commit of repository gentoo-bootstrap: 6b134e018a8bc9f669d8be6d68551aac26badaf4 Timestamp of repository kde: Thu, 26 Oct 2023 22:03:47 +0000 Head commit of repository kde: c6649503022aa3378a4e0e4e3aa381d123cf2d37 Timestamp of repository pg_overlay: Thu, 26 Oct 2023 23:01:49 +0000 Head commit of repository pg_overlay: 9b85506dd2d076fa7734708e4a62c47869d291f7 Timestamp of repository science: Sat, 28 Oct 2023 10:16:47 +0000 Head commit of repository science: c73284210a08aefc561572be84ead8c34d5e7951 sh dash 0.5.12 ld GNU ld (Gentoo 2.41 p2) 2.41.0 distcc 3.4 x86_64-pc-linux-gnu [disabled] ccache version 4.8.3 [enabled] app-misc/pax-utils: 1.3.7::gentoo app-shells/bash: 5.2_p15-r7::gentoo dev-java/java-config: 2.3.1-r1::gentoo dev-lang/perl: 5.38.0-r1::gentoo dev-lang/python: 3.10.13::gentoo, 3.11.6::gentoo, 3.12.0_p1::gentoo dev-lang/rust: 1.72.0-r1::gentoo dev-util/ccache: 4.8.3::gentoo dev-util/cmake: 3.27.7::gentoo dev-util/meson: 1.2.3::gentoo sys-apps/baselayout: 2.14::gentoo sys-apps/openrc: 0.51::gentoo sys-apps/sandbox: 2.38::gentoo sys-devel/autoconf: 2.71-r7::gentoo sys-devel/automake: 1.16.5-r1::gentoo sys-devel/binutils: 2.41-r2::gentoo sys-devel/binutils-config: 5.5::gentoo sys-devel/clang: 15.0.7-r3::gentoo, 16.0.6::gentoo sys-devel/gcc: 13.2.1_p20231014::gentoo sys-devel/gcc-config: 2.11::gentoo sys-devel/libtool: 2.4.7-r1::gentoo sys-devel/llvm: 15.0.7-r3::gentoo, 16.0.6::gentoo sys-devel/make: 4.4.1-r1::gentoo sys-kernel/linux-headers: 6.5-r1::gentoo (virtual/os-headers) sys-libs/glibc: 2.38-r6::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.namerica.gentoo.org/gentoo-portage/ priority: -1000 volatile: False sync-rsync-extra-opts: sync-rsync-verify-metamanifest: no sync-rsync-verify-max-age: 3 sync-rsync-verify-jobs: 1 4nykey location: /var/db/repos/4nykey sync-type: git sync-uri: https://github.com/gentoo-mirror/4nykey.git masters: gentoo volatile: False bitcoin location: /var/db/repos/bitcoin sync-type: git sync-uri: https://github.com/gentoo-mirror/bitcoin.git masters: gentoo volatile: False crossdev location: /var/db/repos/crossdev masters: gentoo volatile: False eigenlay location: /var/db/repos/eigenlay sync-type: git sync-uri: https://github.com/gentoo-mirror/eigenlay.git masters: gentoo volatile: False gentoo-bootstrap location: /var/db/repos/gentoo-bootstrap sync-type: git sync-uri: https://github.com/gentoo-mirror/gentoo-bootstrap.git masters: gentoo volatile: False kde location: /var/db/repos/kde sync-type: git sync-uri: https://github.com/gentoo-mirror/kde.git masters: gentoo volatile: False pg_overlay location: /var/db/repos/pg_overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/pg_overlay.git masters: gentoo volatile: False science location: /var/db/repos/science sync-type: git sync-uri: https://github.com/gentoo-mirror/science.git masters: gentoo volatile: False local location: /var/db/repos/local masters: gentoo priority: 1000 volatile: False ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O3 -ggdb -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/X11/xkb /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /usr/share/i18n/locales/en_US /usr/share/sddm/scripts/Xsetup /usr/share/themes/oxygen-gtk/gtk-2.0 /usr/share/themes/oxygen-gtk/gtk-3.0" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dbus-1 /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.2/ext-active/ /etc/php/cgi-php8.2/ext-active/ /etc/php/cli-php8.2/ext-active/ /etc/php/fpm-php8.2/ext-active/ /etc/php/phpdbg-php8.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d" CXXFLAGS="-march=native -O3 -ggdb -pipe" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--nospinner --unordered-display --verbose-conflicts --autounmask=n --backtrack=100 --usepkg --load-average=8" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live ccache compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms splitdebug strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync warn-on-large-env" FFLAGS="-O2 -pipe" GENTOO_MIRRORS=" http://mirror.leaseweb.com/gentoo/ http://mirrors.rit.edu/gentoo/ http://mirror.csclub.uwaterloo.ca/gentoo-distfiles/ " INSTALL_MASK="/etc/grub.d /etc/pm /etc/systemd /lib/systemd /usr/lib/systemd/system /usr/lib/sysusers.d /etc/xinetd.d /usr/share/bash-completion /usr/share/fish /usr/share/zsh /usr/share/cmake/Help /usr/share/gtk-doc /usr/share/locale/*/ -/usr/share/locale/en -/usr/share/locale/en_US" LANG="en_US.UTF-8" LDFLAGS="-Wl,-O2 -Wl,--as-needed" LEX="flex" LINGUAS="en_US en" MAKEOPTS="-j4 -l8" PKGDIR="/var/cache/binpkgs" PORTAGE_COMPRESS="xz" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git --exclude=/CACHEDIR.TAG" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/bash" USE="X a52 aac acpi alsa amd64 branding bzip2 cairo cdda cdparanoia cdr crypt cups curl dbus declarative dri dts dvd dvdr elogind encode evdev exif ffmpeg flac fontconfig gif git gmp gtk gui iconv icu id3tag ipv6 jpeg kde kwallet lame lcms libnotify libsamplerate libtirpc lzma mad matroska mng mp3 mp4 mpeg multilib ncurses networkmanager nptl ogg opengl opus pam pango pcre pdf php plasma png policykit ppds qml qt5 quicktime readline sctp sdl seccomp smp sound spell ssl startup-notification subversion svg taglib tcmalloc test-rust theora threads tiff truetype udev udisks unicode upower usb v4l vaapi vdpau vnc vorbis vpx vulkan webkit webp widgets x264 xcb xft xml xv xvid xvmc zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2021" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev libinput" KERNEL="linux" L10N="en-US en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11" QEMU_SOFTMMU_TARGETS="arm" RUBY_TARGETS="ruby31" SANE_BACKENDS="genesys" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS ================================================================= Package Settings ================================================================= www-client/chromium-118.0.5993.88::gentoo was built with the following: USE="X cups proprietary-codecs qt5 system-harfbuzz system-icu system-png system-zstd vaapi -custom-cflags -debug -gtk4 -hangouts (-headless) -kerberos (-libcxx) (-lto) -official -pax-kernel (-pgo) -pulseaudio -qt6 -screencast (-selinux) -wayland -widevine" ABI_X86="(64)" L10N="-af -am -ar -bg -bn -ca -cs -da -de -el -en-GB -es -es-419 -et -fa -fi -fil -fr -gu -he -hi -hr -hu -id -it -ja -kn -ko -lt -lv -ml -mr -ms -nb -nl -pl -pt-BR -pt-PT -ro -ru -sk -sl -sr -sv -sw -ta -te -th -tr -uk -ur -vi -zh-CN -zh-TW" CFLAGS="-pipe -march=native -O3" CXXFLAGS="-pipe -fno-tree-vectorize -march=native -O3"
Created attachment 873791 [details, diff] revert-video_frame-notreached_noreturn.patch The attached patch, which reverts only the changes to video_frame.cc that were made in 0ce6af60daa74a14cab3ebe34bc3bff880122467, works around the problem on my system.
Is this still happening with modern Chromium (say, 123)? If so can you provide a link to a video that does cause the crash? Everything _seems_ fine after some brief testing on the Chromium that I built i.e. I can't repro the issue.
(In reply to Matt Jolly from comment #2) > Is this still happening with modern Chromium (say, 123)? If so can you > provide a link to a video that does cause the crash? Everything _seems_ fine > after some brief testing on the Chromium that I built i.e. I can't repro the > issue. I don't know. I have been applying my patch to every new release that I build, and it still applies as of 122.0.6261.111. I'll quickpkg my current installation and rebuild this version without my patch to see if the crashes still occur. I am hesitant to try a newer/unstable version (say, 123) since Chromium effectively trashes the profile if you downgrade, so there is a "ratchet effect," and I don't want to get stuck on a buggy 123.
123 has been released as chromium stable and is in the Gentoo repos with the 0/stable subslot. I need to file a stablereq, but it shouldn't cause any issues.
(In reply to Matt Jolly from comment #4) > 123 has been released as chromium stable and is in the Gentoo repos with the > 0/stable subslot. I need to file a stablereq, but it shouldn't cause any > issues. Great. I'll sync my repo and build that version to test. I'll report back in a few days. (It takes a LOOOONG time to build a new Chromium on my system, as Google does not seem to care about making the Chromium build ccache-friendly across major releases.)
(In reply to Matt Whitlock from comment #5) > (In reply to Matt Jolly from comment #4) > > 123 has been released as chromium stable and is in the Gentoo repos with the > > 0/stable subslot. I need to file a stablereq, but it shouldn't cause any > > issues. > > Great. I'll sync my repo and build that version to test. I'll report back in > a few days. (It takes a LOOOONG time to build a new Chromium on my system, > as Google does not seem to care about making the Chromium build > ccache-friendly across major releases.) Preliminary results indicate that www-client/chromium-123.0.6312.58 no longer crashes even without my patch. :)
