If I touch a gtk-engines ebuild and try to "emerge -pv gtk-engines" I get a bunch of QA notices. Most of them are related to Bug #24439, but the one that says: QA Notice: sed in global scope: x11-themes/gtk-engines-2.6.2 can easily be fixed like this: --- gtk-engines-2.6.2.ebuild 2005-05-05 12:56:00.000000000 +0900 +++ gtk-engines-2.6.2.ebuild 2005-05-05 12:53:54.000000000 +0900 @@ -9 +9 @@ -PVP=($(echo " $PV " | sed 's:[-\._]: :g')) +PVP=(${PV//[-._]/ }) Also, I believe that this piece of code in the gtk-engines2.eclass # --- define some deps for binary packages if [ -n "${HAS_GTK1}" -a ! -n "${HAS_GTK2}" ]; then DEPEND="${DEPEND} =x11-libs/gtk+-1.2*" elif [ -n "${HAS_GTK1}" -a -n "${HAS_GTK2}" ]; then DEPEND="${DEPEND} =x11-libs/gtk+-1.2* =x11-libs/gtk+-2*" elif [ ! -n "${HAS_GTK1}" -a -n "${HAS_GTK2}" ]; then DEPEND="${DEPEND} >=x11-libs/gtk+-2" fi is more readable as: if [ -n "${HAS_GTK1}" ]; then DEPEND="${DEPEND} =x11-libs/gtk+-1.2*" fi if [ -n "${HAS_GTK2}" ]; then DEPEND="${DEPEND} >=x11-libs/gtk+-2" fi or even: [ -n "${HAS_GTK1}" ] && DEPEND="${DEPEND} =x11-libs/gtk+-1.2*" [ -n "${HAS_GTK2}" ] && DEPEND="${DEPEND} >=x11-libs/gtk+-2"
The declaration of PVP is fixed now, thank you for the help. The issues with gtk-engines2.eclass are another story, readability is not the biggest problem there :).
