Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 915138 - net-p2p/feather-2.4.9::guru: compilation failure
Summary: net-p2p/feather-2.4.9::guru: compilation failure
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Adam
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-03 20:41 UTC by Amayak Bo
Modified: 2023-10-10 14:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log with error (build.log,131.86 KB, text/x-log)
2023-10-03 20:43 UTC, Amayak Bo
Details
emerge --info output (emerge_info_output.txt,6.54 KB, text/plain)
2023-10-04 12:22 UTC, Amayak Bo
Details
<cstdint> included patch (gcc.patch,899 bytes, patch)
2023-10-09 15:45 UTC, Amayak Bo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Amayak Bo 2023-10-03 20:41:10 UTC
net-p2p/feather-2.4.9::guru doesn't compile with current stabilized sys-devel/gcc:13, errors about unrecognized ‘uint8_t’ type name in the log

Reproducible: Always

Steps to Reproduce:
1. Install Gentoo from scratch or just upgrade sys-devel/gcc to current stable version (13.2.1_p20230826)
2. Enable GURU ebuild repository
3. Try to install net-p2p/feather::guru
Actual Results:  
* ERROR: net-p2p/feather-2.4.9::guru failed (compile phase):
 *   ninja -v -j8 -l12 feather failed
 * 
 * Call stack:
 *     ebuild.sh, line  136:  Called src_compile
 *   environment, line 2548:  Called cmake_build 'feather'
 *   environment, line  970:  Called eninja 'feather'
 *   environment, line 1453:  Called die
 * The specific snippet of code:
 *       "$@" || die -n "${*} failed"
 * 
 * If you need support, post the output of `emerge --info '=net-p2p/feather-2.4.9::guru'`,
 * the complete build log and the output of `emerge -pqv '=net-p2p/feather-2.4.9::guru'`.
 * The complete build log is located at '/var/tmp/portage/net-p2p/feather-2.4.9/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-p2p/feather-2.4.9/temp/environment'.
 * Working directory: '/var/tmp/portage/net-p2p/feather-2.4.9/work/feather-2.4.9_build'
 * S: '/var/tmp/portage/net-p2p/feather-2.4.9/work/feather-2.4.9'
 * 
 * The following package has failed to build, install, or execute postinst:
 * 
 *  (net-p2p/feather-2.4.9:0/0::guru, ebuild scheduled for merge), Log file:
 *   '/var/tmp/portage/net-p2p/feather-2.4.9/temp/build.log'
 * 

Expected Results:  
Software successful installation
Comment 1 Amayak Bo 2023-10-03 20:43:41 UTC
Created attachment 872108 [details]
build.log with error
Comment 2 Greg Kubaryk 2023-10-03 21:43:34 UTC
Please put the output of 'emerge --info' in a comment.
Comment 3 Amayak Bo 2023-10-04 12:22:34 UTC
Created attachment 872127 [details]
emerge --info output
Comment 4 Mike 2023-10-08 18:26:42 UTC
Probably "#include <cstdint>" should be added.
Comment 5 Amayak Bo 2023-10-09 15:44:40 UTC
(In reply to Mike from comment #4)
> Probably "#include <cstdint>" should be added.

Yep, can be avoided by including the header (sorry not familiar enough with cpp, patch may be incorrect)
Comment 6 Amayak Bo 2023-10-09 15:45:52 UTC
Created attachment 872385 [details, diff]
<cstdint> included patch
Comment 7 Adam 2023-10-09 18:31:13 UTC
I can submit the patch to the upstream developer if you want
Comment 8 Adam 2023-10-09 18:31:28 UTC
this isn't the first time something like this has happened
Comment 9 Amayak Bo 2023-10-09 18:47:12 UTC
(In reply to Adam from comment #8)
> this isn't the first time something like this has happened

Sorry, couldn't find how a similar situations were resolved. Of course you can do what you think is best for this situation, thanks anyway.
Comment 10 Adam 2023-10-09 19:25:58 UTC
(In reply to Amayak Bo from comment #9)
> (In reply to Adam from comment #8)
> > this isn't the first time something like this has happened
> 
> Sorry, couldn't find how a similar situations were resolved. Of course you
> can do what you think is best for this situation, thanks anyway.

I think it might have been a related package like p2pool or monero that also depends on epee (by proxy). There was a problem where it wasn't including some c++ stdlib. I think I fixed it by talking to the developer in IRC.

On closer inspection it seems like these changes have already been made:

https://github.com/feather-wallet/monero/commit/f983ac77805a494ea4a05a00398c553e1359aefd
Comment 11 Adam 2023-10-09 19:46:15 UTC
Perhaps I've failed to update the monero sub-repository commit in the ebuild? It seemed correct at the time.

I will make a feather-2.4.9-r1 with an updated monero commit, see if that works. It compiles for me but I can't reproduce the inital issue myself.
Comment 12 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-10-10 06:45:09 UTC
(In reply to Amayak Bo from comment #5)
> (In reply to Mike from comment #4)
> > Probably "#include <cstdint>" should be added.
> 
> Yep, can be avoided by including the header (sorry not familiar enough with
> cpp, patch may be incorrect)

For future reference, the log says what to do:

/var/tmp/portage/net-p2p/feather-2.4.9/work/feather-2.4.9/monero/contrib/epee/include/storages/parserse_base_utils.h:32:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   31 | #include <boost/utility/string_ref_fwd.hpp>
  +++ |+#include <cstdint>
   32 | #include <string>
Comment 13 Amayak Bo 2023-10-10 07:35:33 UTC
(In reply to Adam from comment #11)
> I will make a feather-2.4.9-r1 with an updated monero commit, see if that works.

Thank you, can confirm feather-2.4.9-r1 installed successful.