Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914890 - media-sound/tuxguitar-1.6.3: multitrack tablature editor and player (Java/Maven) (New package)
Summary: media-sound/tuxguitar-1.6.3: multitrack tablature editor and player (Java/Mav...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL: https://github.com/helge17/tuxguitar
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-28 14:29 UTC by Dominique Michel
Modified: 2024-06-08 06:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tuxguitaar-1.6.0.ebuild (tuxguitar-1.6.0.ebuild,2.70 KB, application/vnd.gentoo.ebuild)
2023-09-28 14:30 UTC, Dominique Michel
Details
tuxguitar launcher (tuxguitar,49 bytes, application/x-shellscript)
2023-09-28 14:31 UTC, Dominique Michel
Details
The script I used to make the archive with the dependencies (make_portage_build,2.84 KB, application/x-shellscript)
2023-09-28 14:38 UTC, Dominique Michel
Details
tuxguitar-1.6.0 ebuild (tuxguitar-1.6.0.ebuild,2.84 KB, application/vnd.gentoo.ebuild)
2023-09-28 16:13 UTC, Dominique Michel
Details
replace the sf2 soundfont by one we have in the main tree (replace-soundfont.patch,2.76 KB, patch)
2023-09-28 16:14 UTC, Dominique Michel
Details | Diff
ebuild with fluidsynth audio driver setup (tuxguitar-1.6.0.ebuild,4.87 KB, application/vnd.gentoo.ebuild)
2023-09-28 19:15 UTC, Dominique Michel
Details
fix typo in ewarn (tuxguitar-1.6.0.ebuild,4.88 KB, application/vnd.gentoo.ebuild)
2023-09-28 19:39 UTC, Dominique Michel
Details
tuxguitar-1.6.3.ebuild (tuxguitar-1.6.3.ebuild,5.52 KB, application/vnd.gentoo.ebuild)
2024-06-07 20:09 UTC, Dominique Michel
Details
metadata.xml (metadata.xml,1.54 KB, text/xml)
2024-06-07 20:10 UTC, Dominique Michel
Details
replace-soundfont_1.6.3.patch (replace-soundfont_1.6.3.patch,2.31 KB, patch)
2024-06-07 20:12 UTC, Dominique Michel
Details | Diff
metadata.xml: fix according to #c8 (metadata.xml,1.53 KB, text/xml)
2024-06-07 21:34 UTC, Dominique Michel
Details
tuxguitar-1.6.3.ebuild: fixes according to #c8 (tuxguitar-1.6.3.ebuild,5.59 KB, application/vnd.gentoo.ebuild)
2024-06-07 21:38 UTC, Dominique Michel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Michel 2023-09-28 14:29:09 UTC
TuxGuitar is an Open Source multitrack tablature editor and player written in Java.

That ebuild have a few particularities because tuxguitar build system changed to marven, and it want to download a lot of dependencies during the build.

So, I made a separate archive with them. That in order to get all that is needed during the unpack phase. Also, that archive contain a copy of marven's settings.xml system file, it is sed edited by the ebuild, that in order for mvn to find the needed dependencies, and not try to download them again during the compilation phase, which would fail.

It would be great if that software can make its way into the main tree again.

Reproducible: Always
Comment 1 Dominique Michel 2023-09-28 14:30:21 UTC
Created attachment 871665 [details]
tuxguitaar-1.6.0.ebuild
Comment 2 Dominique Michel 2023-09-28 14:31:45 UTC
Created attachment 871666 [details]
tuxguitar launcher

Is in $FILESDIR and installed as /usr/bin/tuxguitar.
Comment 3 Dominique Michel 2023-09-28 14:38:19 UTC
Created attachment 871667 [details]
The script I used to make the archive with the dependencies

It is a script I made. Put it into an empty directory and run it. It will download and unpack everything needed to build tuxguitar, build it, launch it (without installing it) and make the archive. Not needed with the ebuild because the ebuild instruct portage to donwload that archive on github.
Comment 4 Dominique Michel 2023-09-28 16:13:23 UTC
Created attachment 871676 [details]
tuxguitar-1.6.0 ebuild

To be used with the replace soundfont patch
Comment 5 Dominique Michel 2023-09-28 16:14:17 UTC
Created attachment 871677 [details, diff]
replace the sf2 soundfont by one we have in the main tree
Comment 6 Dominique Michel 2023-09-28 19:15:21 UTC
Created attachment 871678 [details]
ebuild with fluidsynth audio driver setup

The audio driver of the fluidsynth plugin is hard-coded to pulseaudio. In order to give a choice to the user, that ebuild add several USE flags, one for each available audio driver, their RDEPEND, a test to tell the user what to do, and a sed patch to change that driver to the wanted one.
Comment 7 Dominique Michel 2023-09-28 19:39:21 UTC
Created attachment 871687 [details]
fix typo in ewarn
Comment 8 Jonas Stein gentoo-dev 2023-10-03 11:30:14 UTC
I suggest to clean up the .ebuild and upload it to an overlay till we have a maintainer for this new package.

* add missing || die 
https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#unguarded-external-calls

* Please test the ebuild with pkgcheck scan --net from dev-util/pkgcheck
* use variables where possible https://devmanual.gentoo.org/ebuild-writing/variables/index.html
Comment 9 Dominique Michel 2024-06-07 20:09:58 UTC
Created attachment 895360 [details]
tuxguitar-1.6.3.ebuild
Comment 10 Dominique Michel 2024-06-07 20:10:40 UTC
Created attachment 895361 [details]
metadata.xml
Comment 11 Dominique Michel 2024-06-07 20:12:08 UTC
Created attachment 895362 [details, diff]
replace-soundfont_1.6.3.patch
Comment 12 Dominique Michel 2024-06-07 20:26:09 UTC
I bumped everything to 1.6.3. This also include several changes and simplification.

- The swt archive download is not needed anymore.
- The test for the fluid* USE flag is now in pkg_pretend and launch a premerge check.
- The VST build is marked as deprecated, so I removed it from the ebuild.
- Maybe 1.6.0 was not installing the sh wrapper script tuxguitar.sh. Fixed.
- As tuxguitar's soundfont don't collide with other soundfont in the main tree or the different overlays, and we don't have many of them, the ebuild install it.
- I don't used the shell script to make the bdepends archive. It is replaced by a comment into the ebuild.
- Add metadata.xml
Comment 13 Dominique Michel 2024-06-07 21:34:20 UTC
Created attachment 895368 [details]
metadata.xml: fix according to #c8
Comment 14 Dominique Michel 2024-06-07 21:38:02 UTC
Created attachment 895369 [details]
tuxguitar-1.6.3.ebuild: fixes according to #c8
Comment 15 Dominique Michel 2024-06-07 21:47:12 UTC
(In reply to Jonas Stein from comment #8)
> I suggest to clean up the .ebuild and upload it to an overlay till we have a
> maintainer for this new package.
<snip>

Thanks for the suggestions. I made some cleanup and fixes according to them.

I put tuxguitar into the proaudio-gentoo overlay available via 'eselect repository'.
Comment 16 Volkmar W. Pogatzki 2024-06-08 06:33:02 UTC
(In reply to Dominique Michel from comment #14)
> Created attachment 895369 [details]
> tuxguitar-1.6.3.ebuild: fixes according to #c8

It should be possible to build it the simple way instead of bothering with maven. see the dev-java/batik ebuild as an example.