Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 914191 - [guru] sys-apps/pnpm-bin-8.7.5 does not respect CFLAGS
Summary: [guru] sys-apps/pnpm-bin-8.7.5 does not respect CFLAGS
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Vitaly Zdanevich
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2023-09-14 15:16 UTC by Agostino Sarubbo
Modified: 2024-02-15 14:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,41.28 KB, text/plain)
2023-09-14 15:16 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2023-09-14 15:16:42 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/pnpm-bin-8.7.5 does not respect CFLAGS.
Discovered on: amd64 (internal ref: guru_ci)

NOTE:
To reproduce this issue you may want to add "-frecord-gcc-switches" to CFLAGS/CXXFLAGS/FFLAGS/FCFLAGS. If this is not something about c/c++ context see this bug as an hint to hide the QA warning (with QA_FLAGS_IGNORED) where is not possible to respect CFLAGS.
Comment 1 Agostino Sarubbo gentoo-dev 2023-09-14 15:16:43 UTC
Created attachment 870582 [details]
build.log

build log and emerge --info
Comment 2 Eli Schwartz 2023-11-07 02:46:09 UTC
I don't see how a -bin package could respect CFLAGS given it installs a precompiled binary provided by upstream.
Comment 3 Viorel Munteanu gentoo-dev 2023-11-07 05:45:02 UTC
This is a valid bug.  It should be solved by adding a QA variable to the ebuild (like QA_PREBUILT).  The maintainer tried to fix it with QA_FLAGS_IGNORED, which should also work, but the expression is wrong.
Comment 4 Eli Schwartz 2023-11-13 01:09:16 UTC
It's a bogus bug because the bug implicitly suggests that running a CI to find issues like this, then shotgunning the bugtracker with individual bug reports containing bits and pieces of the actual problem, is going to solve anything. :)

But perhaps Agostino's CI is open source and we can contribute bug fixes to it to make this not happen again? The correct answer is of course that for packages which ship prebuilt upstream binaries, it should indeed use QA_PREBUILT, and the tinderbox CI should detect this case and recommend the correct solution, rather than the wrong one.

*** This bug has been marked as a duplicate of bug 914190 ***
Comment 5 Agostino Sarubbo gentoo-dev 2023-11-13 07:52:52 UTC
Thanks for your hint. However there is nothing broken. They are different problems and then need to be tracked seaprately.
Comment 6 Eli Schwartz 2023-11-14 15:43:03 UTC
They are not different problems! It is semantically incorrect to use QA_FLAGS_IGNORED.

There is a simple and straightforward heuristic that can be automated to detect that these problems should be coalesced into one, and also that the one in question has a different recommended solution than the incorrect suggestion given here.

I will never understand why you are so opposed to the idea of having useful, accurate, reliable CI.
Comment 7 Vitaly Zdanevich 2024-02-15 10:44:59 UTC
SOLVED here https://bugs.gentoo.org/914190#c2
Comment 8 Larry the Git Cow gentoo-dev 2024-02-15 14:58:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=fe242a03ee1867f4fa700680c638156c720d4b52

commit fe242a03ee1867f4fa700680c638156c720d4b52
Author:     Vitaly Zdanevich <zdanevich.vitaly@ya.ru>
AuthorDate: 2024-02-15 10:59:24 +0000
Commit:     Vitaly Zdanevich <zdanevich.vitaly@ya.ru>
CommitDate: 2024-02-15 10:59:24 +0000

    sys-apps/pnpm-bin: replace QA_FLAGS_IGNORED to QA_PREBUILT
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=914190
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=914191
    Signed-off-by: Vitaly Zdanevich <zdanevich.vitaly@ya.ru>

 sys-apps/pnpm-bin/pnpm-bin-8.7.5.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)