github.com/klauspost/compress/zstd code.gitea.io/gitea/modules/public github.com/dlclark/regexp2/syntax github.com/goccy/go-json/internal/encoder/vm_color # code.gitea.io/gitea/modules/public modules/public/bindata.go:3626:30: string not terminated modules/public/bindata.go:3626: syntax error: unexpected EOF in argument list; possibly missing comma or ) gopkg.in/yaml.v2 modules/public/public_test.go ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop_plasma-20230815-233036 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-13 * clang/llvm (if any): clang version 16.0.6 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/16/bin Configuration file: /etc/clang/clang.cfg /usr/lib/llvm/16 16.0.6 Python 3.11.4 Available Rust versions: [1] rust-bin-1.71.1 * The following VMs are available for generation-2: *) Eclipse Temurin JDK 17.0.7_p7 [openjdk-bin-17] Available Java Virtual Machines: [1] openjdk-bin-17 system-vm php cli (if any): go version go1.21.0 linux/amd64 HEAD of ::gentoo commit 4bbf4f5929b3cd5d3b713ff5ccbd8687b4f95e85 Author: Repository mirror & CI <repomirrorci@gentoo.org> Date: Thu Aug 17 08:01:41 2023 +0000 2023-08-17 08:01:40 UTC emerge -qpvO www-apps/gitea [ebuild N ] www-apps/gitea-1.19.3 USE="acct filecaps pam -pie -sqlite"
Created attachment 868064 [details] emerge-info.txt
Created attachment 868065 [details] emerge-history.txt
Created attachment 868066 [details] environment
Created attachment 868067 [details] etc.clang.tar.xz
Created attachment 868068 [details] etc.portage.tar.xz
The file size of ./files/temp.tar.xz is too big (82M) for an upload. For few weeks the link http://tinderbox.zwiebeltoralf.de:31560/17.1_desktop_plasma-20230815-233036/var/tmp/tb/issues/20230817-085552-www-apps_gitea-1.19.3/files/temp.tar.xz is valid.
Created attachment 868069 [details] www-apps:gitea-1.19.3:20230817-085436.log
*** Bug 814614 has been marked as a duplicate of this bug. ***
Can't reproduce this problem with the same golang version (1.21.0), the same gitea src tarball (sha512sum e77372f2354d433f7703d49c3d30238bad3ad6cd0722d4e0fa374692a8a0d6314bb8327807ec2b992ec84de420e09d48aaa3af16ad37b0ee0beb5540f395688f) and all the same compilation options on amd64. File `module/public/bindata.go` is generated by `build/generate-bindata.go` with github.com/shurcooL/vfsgen, however the original generated bindata.go file in question is missing, so I have to wait for the next exception to analyze it further.
em, I hit this in www-apps/gitea-1.21.1, where with dev-lang/go-1.21.4 installed # code.gitea.io/gitea/modules/public modules/public/bindata.go:3144:30: string not terminated modules/public/bindata.go:3144: syntax error: unexpected EOF in argument list; possibly missing comma or ) code.gitea.io/gitea/services/auth/source/sspi
(In reply to Yixun Lan from comment #10) > em, I hit this in www-apps/gitea-1.21.1, where with dev-lang/go-1.21.4 > installed > > # code.gitea.io/gitea/modules/public > modules/public/bindata.go:3144:30: string not terminated > modules/public/bindata.go:3144: syntax error: unexpected EOF in argument > list; possibly missing comma or ) > code.gitea.io/gitea/services/auth/source/sspi The bindata is generated when installing gitea, can you post it?
(In reply to Ryan Qian from comment #11) > The bindata is generated when installing gitea, can you post it? https://dev.gentoo.org/~dlan/logs/bindata.go.xz the file is too large, so I put it here
I have analysed the problem and found that: 1. the generated bindata.go file is fine, compare the hash of the re-generated bindata.go file with the hash of the file above and confirm that they are the same. 2. using the entire /var/tmp/portage/www-apps/gitea-1.21.1 environment which this problem was reproduced, the build passes with just `make gitea` (without regenerating the bindata.go file) 3. I've checked the Go source code and found the relevant code for this problem in the 'src/cmd/compile/internal/syntax' path, here's a detailed trace of the problem: > ``` > syntax -> parser -> scanner -> source > > > (syntax -> read file -> io.Reader) > | > ... > | > V > token: got _Lparen // `(` > | > V > // start from the following `"` character > scanner.next() --> scanner.stdString() --> source.nextch() > | | > | V > | EOF source.ch = -1 **the key problem!!** > | | > | V > | "string not terminated" error > | > V > parser: argList() -> list() -> expr() -> binaryExpr() -> scanner.next() > | | > | V > | source.ch == -1 > | | > | V > | source.lit = "EOF" > | source.tok = _Semi > | > V > syntaxError() > // "syntax error: unexpected EOF in argument list; possibly missing comma or )" > ``` So far it looks like it was compiled without reading the whole file, but the file itself is complete. I'll keep going for deeper reasons.
ci has reproduced this issue with version 1.21.6 - Updating summary.
ci has reproduced this issue with version 1.21.7 - Updating summary.
(In reply to Agostino Sarubbo from comment #15) > ci has reproduced this issue with version 1.21.7 - Updating summary. So weird, I've never reproduced the problem locally, so far it seems to be caused by an incomplete read of the bindata file within a short period of time after it was generated.
