Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 91101 - [PATCH] nvidia-glx should use dlloader USE flag
Summary: [PATCH] nvidia-glx should use dlloader USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-01 20:15 UTC by Donnie Berkholz (RETIRED)
Modified: 2005-07-07 20:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nvidia-glx-1.0.7174-r3.ebuild.patch (nvidia-glx-1.0.7174-r3.ebuild.patch,805 bytes, patch)
2005-05-01 20:16 UTC, Donnie Berkholz (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Donnie Berkholz (RETIRED) gentoo-dev 2005-05-01 20:15:42 UTC
nvidia_drv.so should only be installed on USE=dlloader, and nvidia_drv.o should only be installed if USE=-dlloader. This will avoid potential weird conflicts when both get installed.
Comment 1 Donnie Berkholz (RETIRED) gentoo-dev 2005-05-01 20:16:20 UTC
Created attachment 57790 [details, diff]
nvidia-glx-1.0.7174-r3.ebuild.patch

Adds dlloader flag.
Comment 2 Jeremy Huddleston (RETIRED) gentoo-dev 2005-05-02 00:18:24 UTC
What about using eutils.eclass' built_with_use instead since we care how xorg-x11 was built in this case.  
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2005-05-02 00:32:06 UTC
That doesn't allow for the case where you're "building" a binary for another box, unless you're very tricky with it.
Comment 4 Kris Kersey (RETIRED) gentoo-dev 2005-07-06 08:20:18 UTC
I was going to remove the installation of nvidia_drv.so as Bug #96514 explains a
problem with having both installed.  NVIDIA also does not install this if you
"make install" from their source.  Is this dlloader fix OK with you Jeremy or do
you want to do something more complex?  Can someone direct me to an explanation
of what the dlloader USE flag is for?  It's not in the USE list.
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2005-07-06 11:02:54 UTC
Sure it's on the USE list, xorg-x11 uses it.
Comment 6 Kris Kersey (RETIRED) gentoo-dev 2005-07-06 11:08:28 UTC
I found it in the use.local.desc file, not in the use.desc file.  I agree that
this patch is the way we should go.  Now Jeremy just needs to sign off on it.
Comment 7 Kris Kersey (RETIRED) gentoo-dev 2005-07-07 07:37:12 UTC
Seeing that this bug is over a month old now.  I have taken your fix with a
minor modification and applied it to version 1.0.7664 and 1.0.7667 of the
driver.  If there is a better fix for this, we can apply it later.  This will
resolve Bug #96514 also.
Comment 8 Donnie Berkholz (RETIRED) gentoo-dev 2005-07-07 14:53:01 UTC
Augustus, how about use.local.desc?
Comment 9 Kris Kersey (RETIRED) gentoo-dev 2005-07-07 15:17:21 UTC
What did I miss?
Comment 10 Joshua Baergen (RETIRED) gentoo-dev 2005-07-07 16:31:20 UTC
There doesn't seem to be an entry in use.local.desc for nvidia-glx, even though
the flag exists in IUSE now.  Maybe this should be moved to use.desc instead
since it's used on multiple packages.
Comment 11 Kris Kersey (RETIRED) gentoo-dev 2005-07-07 19:40:56 UTC
I think I'm suppose to add it.  It doesn't seem auto generated.  Is that what I
should do?
Comment 12 Joshua Baergen (RETIRED) gentoo-dev 2005-07-07 19:54:29 UTC
Ya, you have to add it.  Donnie, should we consider making this a global use
flag instead of local?
Comment 13 Donnie Berkholz (RETIRED) gentoo-dev 2005-07-07 19:59:45 UTC
No, it's not in wide enough use for global.
Comment 14 Kris Kersey (RETIRED) gentoo-dev 2005-07-07 20:56:32 UTC
I have added the entry.  I man re-resolving this bug.  Thanks for the info guys.