Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 9104 - tleds ignores "-X11" in /etc/make.conf
Summary: tleds ignores "-X11" in /etc/make.conf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-14 02:12 UTC by Ossor
Modified: 2002-10-14 19:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tleds-1.05_beta11.diff (tleds-1.05_beta11.diff,1.15 KB, text/plain)
2002-10-14 03:45 UTC, Maurizio Disimino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ossor 2002-10-14 02:12:23 UTC
I have "-X11" in the USE Flags in /etc/make.conf  
When emerging tleds, it will first build tleds and then tries to build 
xtleds even if X is not installed, which leads to stop the ebuild with missing 
X Libs. 
 
Could the ebuild be improved to only build "tleds" when "-X11" is given in USE 
or X is not installed at all?
Comment 1 Maurizio Disimino 2002-10-14 02:42:36 UTC
"X11" is NOT a valid useflag. Use "X" instead.
The /usr/portage/profiles/use.desc lists all the useflag available.

# grep ^X /usr/portage/profiles/use.desc
X - Adds support for XFree86

Maurizio
Comment 2 Ossor 2002-10-14 02:55:45 UTC
Sorry I was wrong in my bug description. Of course I have "X" as the flag, not X11.   
Comment 3 Maurizio Disimino 2002-10-14 03:45:56 UTC
Created attachment 4690 [details]
tleds-1.05_beta11.diff

Here's the patch. Apply it to the net-analyzer/tleds-1.05_beta11.ebuild.

Maurizio
Comment 4 SpanKY gentoo-dev 2002-10-14 19:11:37 UTC
damn you and your `sed`ing for CFLAGS ;) 
 
also, you like to do `sed old > new ; mv new old` ... while this gets the job 
done in 2 steps without leaving behind any files, this wont work if you're 
doing it on a script ... 
 
the creation of the file by piping into it will set the permissions based upon 
the umask instead of the original permissions (which is even worse if you use 
ACL's on your system) 
 
thats why i do `cp new old ; sed old > new ; rm old` ... 
just an FYI ;) 
Comment 5 SpanKY gentoo-dev 2002-10-14 19:53:30 UTC
thx guys, fix is in CVS