Bug 909147 – Prefixify script shebangs for ebuilds with EAPI newer than 7

• Status: CONFIRMED
• Product: Portage Development

[Description Benda Xu 2023-06-25 07:50:50 UTC]

bin/install-qa-check.d/05prefix: do not prepend slash to the path.

D after EAPI 7 has no trailing slash. Prepending a slash to fp makes
it '//' and does not match elements in PATH.

With this fix, the shebangs from ebuilds with EAPIs newer than 7 are
prefixified again.

This patch delibrately ignores EAPI <7 ebuilds.  They should get EAPIs
bumped.


Reproducible: Always

[Comment 1 Benda Xu 2023-06-25 07:51:12 UTC]

Created attachment 864589 [details, diff]
bin-install-qa-check.d-05prefix-do-not-prepend-slash.patch

[Comment 2 Fabian Groffen 2023-06-25 07:56:10 UTC]

how about

        local fp=${fn#${D%/}/} ; fp=/${fp%/*}

That should cover all cases?

[Comment 3 Benda Xu 2023-06-25 08:41:47 UTC]

(In reply to Fabian Groffen from comment #2)
> how about
> 
>         local fp=${fn#${D%/}/} ; fp=/${fp%/*}
> 
> That should cover all cases?

Yes, actually

  local fp=${fn#${D%/}} ; fp=${fp%/*}

is more concise.