Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 907500 - sys-apps/flashrom-1.3.0 register_spi_master called with incomplete master definition
Summary: sys-apps/flashrom-1.3.0 register_spi_master called with incomplete master def...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL: https://github.com/flashrom/flashrom/...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-05-31 23:04 UTC by David Duchesne
Modified: 2023-06-13 07:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Duchesne 2023-05-31 23:04:03 UTC
After upgrading to sys-apps/flashrom-1.3.0, I can't read my chip anymore:

flashrom v1.3.0 on Linux 6.1.31-gentoo-gnu-hardened (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
coreboot table found at 0x7f76e000.
Found chipset "Intel ICH7/ICH7R".
Enabling flash write... WARNING: SPI Configuration Lockdown activated.
register_spi_master called with incomplete master definition. Please report a bug at flashrom@flashrom.org
OK.
No EEPROM/flash device found.
Note: flashrom can never write if the flash chip isn't found automatically.

I looked at flashrom git code and after several pass of checkout/make, I found this commit solves the issue :
https://github.com/flashrom/flashrom/commit/e1f30bbce7a603d518ecec9d7e6885719f396719

flashrom v1.2-1222-ge1f30bbc on Linux 6.1.31-gentoo-gnu-hardened (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
coreboot table found at 0x7f76e000.
Found chipset "Intel ICH7/ICH7R".
Enabling flash write... WARNING: SPI Configuration Lockdown activated.
OK.
Found Winbond flash chip "W25Q128.V" (16384 kB, SPI) mapped at physical address 0x00000000ff000000.
No operations were specified.

Unfortunately, I can't just add .patch to the above url and use that temporarily until a new release is out since a lot of code was changed meanwhile and patching 1.3.0 fails.
Otherwise, I can still use 1.2-r4 ebuild, I hope it will not be removed too quickly.

Reproducible: Always
Comment 1 Marek Szuba archtester gentoo-dev 2023-06-12 23:22:45 UTC
Thank you for the report. Could you check if 1.3.0-r1 - which I've just pushed to the tree - fixes the problem for you?
Comment 2 David Duchesne 2023-06-13 06:32:53 UTC
@Marek Szuba

All good, reading/writing the chip now works fine again, thanks !

----
$ flashrom -p internal -r dump.rom
flashrom v1.3.0 on Linux 6.1.31-gentoo-gnu-hardened (x86_64)
flashrom is free software, get the source code at https://flashrom.org

Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns).
coreboot table found at 0x7f76f000.
Found chipset "Intel ICH7/ICH7R".
Enabling flash write... WARNING: SPI Configuration Lockdown activated.
OK.
Found Winbond flash chip "W25Q128.V" (16384 kB, SPI) mapped at physical address 0x00000000ff000000.
===
This flash part has status UNTESTED for operations: WP
The test status of this chip may have been updated in the latest development
version of flashrom. If you are running the latest development version,
please email a report to flashrom@flashrom.org if any of the above operations
work correctly for you with this flash chip. Please include the flashrom log
file for all operations you tested (see the man page for details), and mention
which mainboard or programmer you tested in the subject line.
Thanks for your help!
Reading flash... done.
----
Comment 3 Marek Szuba archtester gentoo-dev 2023-06-13 07:38:43 UTC
(In reply to David Duchesne from comment #2)

> All good, reading/writing the chip now works fine again, thanks !

Great!

***

For reference, fixed by bee3bcde7d86726cb8386d85a4c93b8d5df7aced .