Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906992 - [PATCH] www-client/firefox-113.0.1: add accessibility use flag
Summary: [PATCH] www-client/firefox-113.0.1: add accessibility use flag
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-23 12:07 UTC by Morteza
Modified: 2023-07-19 07:13 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to add accessibility use flag (0001-www-client-firefox-add-accessibility-use-flag.patch,1.61 KB, patch)
2023-05-23 12:08 UTC, Morteza
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Morteza 2023-05-23 12:07:30 UTC
Hope it's the right place to send patches if it's not let me know

Reproducible: Always
Comment 1 Morteza 2023-05-23 12:08:32 UTC
Created attachment 862266 [details, diff]
Patch to add accessibility use flag
Comment 2 Matt Turner gentoo-dev 2023-05-24 17:15:51 UTC
That allows you to avoid a dependency on app-accessibility/at-spi2-core -- because you want to avoid dbus?
Comment 3 Morteza 2023-05-24 19:01:12 UTC
unfortunately it doesn't get rid of at-spi2-core dependency as gtk+ is hard wired to at-spi2-core, there's a patch from kisslinux to get rid of that but i don't think it will be accepted in gentoo
anyhow it get rid of a runtime dependency which is a plus imo
Comment 4 Joonas Niilola gentoo-dev 2023-05-29 16:27:07 UTC
I would say conceptually this is fine, but 

1) I'm kind of vary in adding more use flags to firefox, we got 'valgrind' coming soon too,
2) what _exactly_ does disabling accessibility do? 

Should the configure option be tied to "-dbus" instead? And as you've noted yourself, avoiding dbus with dep chains is impossible at this time, so if that's the only reason I don't see much point to this. However if there's a noticeable technical difference with enabling/disabling accessibility, then we'll figure out something.
Comment 5 Joonas Niilola gentoo-dev 2023-07-19 07:13:39 UTC
Can't do much distro-wise until it's fixed in GTK.