Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 90531 - qt-3.3.4 bigdesktop patch
Summary: qt-3.3.4 bigdesktop patch
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-26 13:05 UTC by Stuart Marsden
Modified: 2005-06-08 13:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qt-3.3.4-r4.ebuild (update) (qt-3.3.4-r4.ebuild,8.58 KB, text/plain)
2005-04-26 13:11 UTC, Stuart Marsden
Details
qt-3.3.4-bigdesktop.patch (new) (qt-3.3.4-bigdesktop.patch,2.36 KB, patch)
2005-04-26 13:13 UTC, Stuart Marsden
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stuart Marsden 2005-04-26 13:05:09 UTC
This new ebuild for qt applies my new bigdesktop patch. The patch is primarly designed for ATI graphics card users that use the Bigdesktop mode.  This patch means that when a setting is made in the qtrc file the desktop is split horizontally and treated as though 2 xinerama screens are available.

The setting defaults to false and thus will have no effect for other users.
The patch was developed on a amd64 system but should not be arch specific.

The patch was posted on the forum here:

http://forums.gentoo.org/viewtopic-t-325252-highlight-.html

and has been succesfully applied by one other user so far.
Comment 1 Stuart Marsden 2005-04-26 13:11:59 UTC
Created attachment 57313 [details]
qt-3.3.4-r4.ebuild (update)

Just adds the lines:

# patch the desktop so it can be split
epatch ${FILESDIR}/${P}-bigdesktop.patch

to qt-3.3.4-r3.ebuild
Comment 2 Stuart Marsden 2005-04-26 13:13:51 UTC
Created attachment 57314 [details, diff]
qt-3.3.4-bigdesktop.patch (new)

This patch updates the file 

/src/kernel/qdesktopwidget_x11.cpp
Comment 3 Stuart Marsden 2005-04-26 13:35:00 UTC
I forgot to say once patch is applied absolutley nothing different should happen until you add this to your qtrc file:

[Desktop]
bigdesktop=true 
Comment 4 Gregorio Guidi (RETIRED) gentoo-dev 2005-05-12 15:55:44 UTC
Usually we only accept patches that are already approved by the upstream source, we prefer to not provide and maintain Gentoo-specific customizations.
So, I don't think we can apply the patch.

Any other opinion from the kde herd?
Comment 5 Timo A. Hummel 2005-06-07 16:01:56 UTC
Well, it's kinda tricky.   
   
Gentoo won't accept the patch as we want it to have approved by the upstream 
source. KDE won't accept the patch as it's a QT issue only in relation to ATI's 
fglrx driver, and QT won't accept the bug either. 
 
So what shall we do? 
 
 
Comment 6 Gregorio Guidi (RETIRED) gentoo-dev 2005-06-08 02:01:20 UTC
Everyone is free to apply the patches himself, but we cannot really provide 
support for them, so they cannot be applied. 
Comment 7 Gregorio Guidi (RETIRED) gentoo-dev 2005-06-08 02:01:28 UTC
Everyone is free to apply the patches himself, but we cannot really provide 
support for them, so they cannot be applied. 
Comment 8 Stuart Marsden 2005-06-08 13:34:33 UTC
I understand the reasons for not accepting the patch.

Qt does not seem to have an easy way to submit patches that I can find. Anyone
have a contact there?

I do not have the time or patience to start e-mailing trolltech and trying to
get it accepted. With qt 4 about to come out I doubt they will be interested in
any point release for qt 3. I do not know if the patch can be made to work with
qt 4. I do not run too much beta software so probably will not look at qt 4
until kde 4 comes out.

For the time being I guess people can just apply the patch themselves if needed.