Bug 904500 – x11-terms/xfce4-terminal: build fails with xfce-base/libxfce4ui-4.19.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Felix Neumärker 2023-04-18 06:38:31 UTC]

compile phase crashes while linking:
ld: terminal-window.c:(.text+0x176f): undefined reference to `xfce_gtk_menu_append_seperator'

Reproducible: Always

Steps to Reproduce:
1.Build xfce4-terminal with xfce-base/libxfce4ui=4.9.0
Actual Results:  
Crashes with ld:
ld: terminal-window.c:(.text+0x176f): undefined reference to `xfce_gtk_menu_append_seperator'

[Comment 1 Marcin Deranek 2023-04-18 07:35:25 UTC]

I believe you meant xfce-base/libxfce4ui-4.19.0. I ran into the very same problem (Cannot run terminal after an update).

[Comment 2 Sam James 2023-04-18 07:40:18 UTC]

Please always include the full build.log and emerge --info.

Also, this is a great example of where implicit function declarations lead to a worse error message :(

[Comment 3 Felix Neumärker 2023-04-18 09:18:49 UTC]

yes sorry for the typo.

[Comment 4 Felix Neumärker 2023-04-18 09:59:34 UTC]

This MR https://gitlab.xfce.org/xfce/libxfce4ui/-/merge_requests/88
broke the behavior to accept both (alias).
would also be possible to patch libxfce4ui as there might be other xfce4 apps affected?

[Comment 5 Andreas 2023-04-18 16:50:44 UTC]

Same happening to me ie CANT open terminal.
xfce-base/libxfce4ui-4.19.0
is bad.
"Cant execute default terminal emulator
IO error"

[Comment 6 Andreas 2023-04-18 16:52:37 UTC]

Not the xfce4-terminal is to blame.
Rather libxfce4ui-4.19.0

[Comment 7 Felix Neumärker 2023-04-18 17:51:25 UTC]

> Not the xfce4-terminal is to blame.
> Rather libxfce4ui-4.19.0

it depends, libxfce4ui-4.19.0 cleaned up things...

----------
https://whichiscorrect.com/seperator-vs-separator/

“seperator”

--> Incorrect spelling, explanation: this is tricky, as the [ə] sound in pronunciation can be represented by both a and e in writing. Still, seperator is an incorrect word, because the base word here is separate, from the Latin separare. There is no reason why the English borrowing would change vowels in this kind of manner, so separator is the only correct version.
-----------

but yes as mentioned in the PR reverse apply of https://gitlab.xfce.org/xfce/libxfce4ui/-/merge_requests/88/diffs?commit_id=08076f487296a7a9673ad7e8547a48ba41beb74f

to libxfce4 might be the better fix here.

[Comment 8 Felix Neumärker 2023-04-18 18:09:14 UTC]

Created attachment 860336 [details, diff]
Patch for xfce-base/libxfce4ui-4.19.0

this is the reverse patch for xfce-base/libxfce4ui-4.19.0, which allows backward compatibility: (e.g. /etc/portage/patches/xfce-base/libxfce4ui-4.19.0)

[Comment 9 Michał Górny 2023-04-18 18:25:21 UTC]

I'm sorry about that.  I have expected XFCE upstream to hold higher standards than that.  I'm going to mask this version without delay.

[Comment 10 ZetaCorvi 2023-06-08 19:01:54 UTC]

New version is released a month ago, with that typo fixed
https://mail.xfce.org/pipermail/xfce-announce/2023-April/001282.html
Close the bug pls

[Comment 11 ZetaCorvi 2023-12-30 18:51:29 UTC]

Close the bug pls, this issue was resolved months ago

[Comment 12 Michał Górny 2023-12-30 19:15:02 UTC]

Thanks for the reminder!