Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 904087 - sys-fs/zfs-kmod should not always require CONFIG_MODULES
Summary: sys-fs/zfs-kmod should not always require CONFIG_MODULES
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Sam James
URL: https://wiki.gentoo.org/wiki/ZFS#Inst...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-10 01:20 UTC by Justus Ranvier
Modified: 2024-02-14 10:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justus Ranvier 2023-04-10 01:20:19 UTC
The instructions on the wiki for installing zfs into the kernel source requires one to run the configure step of the ebuild only without actually installing the package.

This will fail unless CONFIG_MODULES=y is set in the kernel source directory, however this may be completely unnecessary because one of the reasons to copy the driver into the kernel source is precisely to enable the use of zfs with a non-modular kernel.

Ideally this check would be behind a USE flag which could be turned off for users who only need to to use the copy-builtin script. Since sys-fs/zfs uses the kernel-builtin flag for this scenario it would make sense for that flag to also apply to sys-fs/zfs-kmod and if set disable the check for CONFIG_MODULES=y.

Reproducible: Always
Comment 1 Georgy Yakovlev archtester gentoo-dev 2023-04-17 20:40:40 UTC
Flag would be overkill for it, we can simply do this instead:

has '--enable-linux-builtin' ${EXTRA_ECONF} || CONFIG_CHECK+=" MODULES"

I'll test it a bit and will add something later.