Bug 90325 – Patches to break apart the set_network_data function.

• Status: RESOLVED FIXED
• Product: Gentoo Release Media

[Description Christopher Hotchkiss 2005-04-24 21:15:50 UTC]

These patches break apart the GLIClientConfiguration/set_network_data function. On top of making the code more readable it has some rather nice side effects.

The serialize function has shrunk.
The set_network_type function is more inutitive.
The overall code size has not changed.
Bug #90143 is also resolved.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Christopher Hotchkiss 2005-04-24 21:22:49 UTC]

Created attachment 57142 [details, diff]
GLIClientConfiguration.py.patch

[Comment 2 Christopher Hotchkiss 2005-04-24 21:23:11 UTC]

Created attachment 57143 [details, diff]
GLIClientController.py.patch

[Comment 3 Christopher Hotchkiss 2005-04-24 21:23:33 UTC]

Created attachment 57144 [details, diff]
dialogfe.py.patch

[Comment 4 Christopher Hotchkiss 2005-04-24 21:25:53 UTC]

*** Bug 90143 has been marked as a duplicate of this bug. ***

[Comment 5 Christopher Hotchkiss 2005-04-27 13:41:38 UTC]

Created attachment 57433 [details, diff]
GLIClientConfiguration.py

Fixed patch. Had a couple bugs ;)

[Comment 6 Christopher Hotchkiss 2005-04-27 13:45:00 UTC]

Created attachment 57434 [details, diff]
GLIClientController.py

Fixed some bugs. ;)

[Comment 7 Christopher Hotchkiss 2005-04-27 13:46:06 UTC]

Created attachment 57435 [details, diff]
dialogfe.py

Fixed some really dumb bugs. ;)

[Comment 8 Preston Cody (RETIRED) 2005-04-28 23:30:20 UTC]

most of it made CVS.  proxy stuff was done separately.

[Comment 9 Jeffrey Forman (RETIRED) 2006-03-24 13:46:28 UTC]

Moving to Release Media/Installer.