Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 902483 - media-libs/netpbm-11.1.1: -Wreturn-type warnings
Summary: media-libs/netpbm-11.1.1: -Wreturn-type warnings
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Viorel Munteanu
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-03-20 22:23 UTC by Sam James
Modified: 2023-03-31 06:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_902483.txt,87.67 KB, text/plain)
2023-03-20 22:23 UTC, Sam James
Details
fix the warnings (netpbm-11.2.0-return-type-warnings.patch,1.27 KB, text/plain)
2023-03-29 05:56 UTC, Viorel Munteanu
Details
fix the warnings - take 2 (netpbm-11.2.0-return-type-warnings.patch,1.70 KB, text/plain)
2023-03-31 06:56 UTC, Viorel Munteanu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-20 22:23:28 UTC
Created attachment 858499 [details]
build.log

Note that I'm setting -Werror=return-type myself, but it's generally a problematic warning. Clang in particular aggressively optimises based on it.

x86_64-pc-linux-gnu-gcc -Wall -c -I.  -I"/var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1"/importinc  -I/var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1/lib  -DNDEBUG   -fPIC  -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wformat -Werror=int-conversion -Waddress -Warray-bounds -Wfree-nonheap-object -Wimplicit-function-declaration -Wimplicit-int -Wincompatible-pointer-types -Wint-conversion -Wint-to-pointer-cast -Wmain -Wnonnull -Wodr -Wparentheses -Wreturn-type -Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstring-compare -Wuninitialized -Wunused-value -Wvarargs  -o libsystem.o libsystem.c
make -C util/ -f /var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1/lib/util/Makefile \
	SRCDIR=/var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1 BUILDDIR=/var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1 bitio.o 
libpnm3.c: In function ‘pnm_bittoxel’:
libpnm3.c:437:1: error: control reaches end of non-void function [-Werror=return-type[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wreturn-type]]
  437 | }
      | ^
make[2]: Entering directory '/var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1/lib/util'
make[2]: 'bitio.o' is up to date.
make[2]: Leaving directory '/var/tmp/portage/media-libs/netpbm-11.1.1/work/netpbm-11.1.1/lib/util'
libpbmfont0.c: In function ‘pbm_defaultfont’:
libpbmfont0.c:44:12: warning: ‘retval’ may be used uninitialized [-Wmaybe-uninitialized[https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wmaybe-uninitialized]]
   44 |     return retval;
      |            ^~~~~~
libpbmfont0.c:35:19: note: ‘retval’ was declared here
   35 |     struct font * retval;
      |                   ^~~~~~
[...]
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-20 22:23:58 UTC
$ emerge --info
Portage 3.0.45.3 (python 3.11.2-final-0, default/linux/amd64/17.1/hardened, gcc-13, glibc-2.37-r1, 6.1.20-gentoo-dist-hardened x86_64)
=================================================================
System uname: Linux-6.1.20-gentoo-dist-hardened-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-glibc2.37
KiB Mem:    65746424 total,   3100796 free
KiB Swap:    8290300 total,   7739644 free
Timestamp of repository gentoo: Mon, 20 Mar 2023 22:02:02 +0000
Head commit of repository gentoo: 315ab9b1d849129a4422361f75bd979a4edbb98c

Timestamp of repository emacs: Fri, 17 Mar 2023 22:18:27 +0000
Head commit of repository emacs: b29552059b1ad0e13b6d3fb0d7e90a86f14aa0cb

Timestamp of repository kde: Fri, 17 Mar 2023 22:18:47 +0000
Head commit of repository kde: a6d11cffd54ef372e36f74edd5985de2438942a1

Timestamp of repository qt: Sat, 18 Mar 2023 21:49:46 +0000
Head commit of repository qt: a0a2ab00e8f4b975d5210365ec2260bf4515e4bd

Timestamp of repository sam_c: Sat, 18 Mar 2023 21:49:57 +0000
Head commit of repository sam_c: 9669e03cf446af625583efdaa92f92a1a25d2570

Timestamp of repository steam-overlay: Sat, 18 Mar 2023 21:49:46 +0000
Head commit of repository steam-overlay: 63f771c440e36af52b2d2dbda6293ac0840a2c95

sh dash 0.5.12
ld GNU ld (Gentoo 2.40 p3) 2.40.0
ccache version 4.8 [disabled]
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p15-r2::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.36.0-r2::gentoo
dev-lang/python:           3.9.16_p3::gentoo, 3.10.10_p3::gentoo, 3.11.2_p2::gentoo, 3.12.0_alpha6::gentoo
dev-lang/rust:             1.67.1::gentoo
dev-util/ccache:           4.8::gentoo
dev-util/cmake:            3.26.0::gentoo
dev-util/meson:            1.0.1::gentoo
sys-apps/baselayout:       2.13-r1::gentoo
sys-apps/sandbox:          2.30-r1::gentoo
sys-apps/systemd:          253.1::gentoo
sys-devel/autoconf:        2.13-r7::gentoo, 2.69-r8::gentoo, 2.71-r5::gentoo, 9999::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.40-r3::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           15.0.7-r1::gentoo, 16.0.0::gentoo, 17.0.0_pre20230314::gentoo
sys-devel/gcc:             10.4.1_p20230316::gentoo, 11.3.1_p20230317::gentoo, 12.2.1_p20230318::gentoo, 13.0.1_pre20230319::gentoo
sys-devel/gcc-config:      2.10::gentoo
sys-devel/libtool:         2.4.7-r1::gentoo
sys-devel/lld:             17.0.0_pre20230314::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo, 15.0.7::gentoo, 16.0.0::gentoo, 17.0.0_pre20230314::gentoo
sys-devel/make:            4.4.1::gentoo
sys-kernel/linux-headers:  6.2::gentoo (virtual/os-headers)
sys-libs/glibc:            2.37-r1::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: sam_c
    volatile: False
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    eclass-overrides: sam_c
    volatile: True

emacs
    location: /var/db/repos/emacs
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/emacs.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

kde
    location: /var/db/repos/kde
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/kde.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

qt
    location: /var/db/repos/qt
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/qt.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

test
    location: /var/db/repos/test
    masters: gentoo
    eclass-overrides: sam_c
    volatile: False

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.2/ext-active/ /etc/php/cgi-php8.2/ext-active/ /etc/php/cli-php8.2/ext-active/ /etc/php/fpm-php8.2/ext-active/ /etc/php/phpdbg-php8.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --with-bdeps=y --complete-graph --deep --dynamic-deps=n --changed-deps=n --usepkg-exclude sys-fs/zfs --usepkg-exclude sys-fs/zfs-kmod --usepkg=y --implicit-system-deps=n --jobs=4 --load-average 32"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg cgroup clean-logs config-protect-if-modified distlocks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type"
GENTOO_MIRRORS="http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/"
LANG="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-z,pack-relative-relocs"
LEX="reflex"
LINGUAS="en en_GB"
MAKEOPTS="-j32 -l32"
PKGDIR="/var/cache/binpkgs"
PORTAGE_BUNZIP2_COMMAND="lbunzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RUSTFLAGS="-C target-cpu=native"
SHELL="/bin/bash"
USE="PIC X a52 aac acl acpi activities aes alsa amd64 avx avx2 bash-completion bluetooth branding bzip2 cairo caps cdda cdr cet clang cli crypt dbus declarative dist-kernel dri dts dvd dvdr emacs encode exif f16c filecaps firewalld flac fma3 fortran freetype gdbm gif gmp gpm graphite gtk gui hardened harfbuzz hunspell iconv icu ipv6 jit jpeg kde kdesu kwallet lcms libglvnd libnotify libtirpc lto mad mmx mmxext mng mp3 mp4 mpeg multilib ncurses nftables nls nptl ogg opengl openmp pam pango pclmul pcre pdf pgo pie pipewire plasma png policykit popcnt ppds pulseaudio qml qt5 rdrand readline screencast sdl seccomp semantic-desktop sha sound spell sse sse2 sse3 sse4_1 sse4_2 sse4a ssl ssp ssse3 startup-notification svg system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libvpx system-libyaml system-llvm system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib systemd test-rust tiff truetype udev udisks unicode upower usb verify-sig vorbis vulkan wayland widgets x264 xattr xcb xft xml xtpax xv xvid zfs zlib zsh-completion" ABI_X86="32 64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_10 pypy3 python3_11 python3_8 python3_9" QEMU_USER_TARGETS="aarch64 aarch64_be alpha armeb hppa m68k ppc ppc64 ppc64le sparc sparc64" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
YACC="byacc"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, SIZE, STRINGS, STRIP, YFLAGS
Comment 2 Viorel Munteanu gentoo-dev 2023-03-29 05:56:01 UTC
Created attachment 859223 [details]
fix the warnings
Comment 3 Viorel Munteanu gentoo-dev 2023-03-29 05:57:00 UTC
I checked.  All of them are "impossible" cases, please check the attached patch.  Not sure it's worth fixing.

Also _Noreturn is deprecated in C23 and replaced by [[noreturn]], and the package does not use autoconf to easily test this.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-03-29 18:53:29 UTC
Thanks, I'll check this soon.
Comment 5 Viorel Munteanu gentoo-dev 2023-03-31 06:56:39 UTC
Created attachment 859309 [details]
fix the warnings - take 2

Same as before but added a macro for _Noreturn