Bug 901455 – net-libs/libsoup-3.2.2: fails to compile with -O3 (soup-body-input-stream.c:234:21: error: argument 1 null where non-null expected [-Werror=nonnull])

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Piotr Karbowski (RETIRED) 2023-03-16 08:24:11 UTC]

Created attachment 857975 [details]
build.log

On the current ~amd64 system I am unable to build libsoap. Relevant part of build.log below, enter build.log attached to the bug.

FAILED: libsoup/libsoup-3.0.so.0.6.0.p/http1_soup-body-input-stream.c.o                                                                                        
x86_64-pc-linux-gnu-gcc -Ilibsoup/libsoup-3.0.so.0.6.0.p -Ilibsoup -I../libsoup-3.2.2/libsoup -I. -I../libsoup-3.2.2 -I../libsoup-3.2.2/libsoup/auth -I../libsoup-3.2.2/libsoup/cookies -I../libsoup-3.2.2/libsoup/content-decoder -I../libsoup-3.2.2/libsoup/hsts -I../libsoup-3.2.2/libsoup/http1 -I../libsoup-3.2.2/libsoup/http2 -I../libsoup-3.2.2/libsoup/server -I../libsoup-3.2.2/libsoup/server/http1 -I../libsoup-3.2.2/libsoup/server/http2 -I../libsoup-3.2.2/libsoup/websocket -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -fvisibility=hidden -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -D_DEFAULT_SOURCE -DHAVE_CONFIG_H -Wmissing-include-dirs -Wpointer-arith -Winit-self -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=aggregate-return -Werror=format=2 -Werror=return-type -Wincompatible-pointer-types -Wstrict-prototypes -Wno-format-zero-length -Wno-missing-include-dirs -Wno-unused-parameter -Wno-sign-compare -Wno-cast-function-type -Wno-missing-field-initializers -O3 -pipe -march=znver2 -fPIC -pthread '-DG_LOG_DOMAIN="libsoup"' -DLIBSOUP_COMPILATION -MD -MQ libsoup/libsoup-3.0.so.0.6.0.p/http1_soup-body-input-stream.c.o -MF libsoup/libsoup-3.0.so.0.6.0.p/http1_soup-body-input-stream.c.o.d -o libsoup/libsoup-3.0.so.0.6.0.p/http1_soup-body-input-stream.c.o -c ../libsoup-3.2.2/libsoup/http1/soup-body-input-stream.c                                                                                                                    
In function ‘soup_body_input_stream_read_chunked’,                                                                                                             
    inlined from ‘read_internal’ at ../libsoup-3.2.2/libsoup/http1/soup-body-input-stream.c:267:10,                                                            
    inlined from ‘soup_body_input_stream_skip’ at ../libsoup-3.2.2/libsoup/http1/soup-body-input-stream.c:298:16:                                              
../libsoup-3.2.2/libsoup/http1/soup-body-input-stream.c:234:21: error: argument 1 null where non-null expected [-Werror=nonnull]                               
  234 |                 if (strncmp (buffer, "\r\n", nread) || strncmp (buffer, "\n", nread)) {

[Comment 1 James Harvey 2023-03-17 03:53:57 UTC]

I also ran into this issue, solved for me by downgrading from glib-2.76.0-r1 to glib-2.74.6

[Comment 2 Sam James 2023-03-17 04:10:32 UTC]

This is likely fixed by:

commit ab4518e2e6285248b51674cff0987eb0ca86fd5d
Author: Sam James <[e-mail]>
Date:   Thu Mar 16 23:49:14 2023 +0000

    dev-libs/glib: drop 2.76.0

    Signed-off-by: Sam James <[e-mail]>

commit 5b9054009ad1ec24f32e5122f71993d25a15c130
Author: Sam James <[e-mail]>
Date:   Thu Mar 16 23:48:43 2023 +0000

    profiles: mask broken =dev-libs/glib-2.76.0

    Bug: https://bugs.gentoo.org/901211
    Bug: https://bugs.gentoo.org/901035
    Signed-off-by: Sam James <[e-mail]>

commit 494fdf6d476ec4dfa6b6c801b66709765bdce45a
Author: Sam James <[e-mail]>
Date:   Thu Mar 16 23:47:33 2023 +0000

    dev-libs/glib: backport fix for building C++ applications

    Closes: https://bugs.gentoo.org/901211
    Closes: https://bugs.gentoo.org/901035
    Signed-off-by: Sam James <[e-mail]>

Can you confirm?

[Comment 3 Sam James 2023-03-17 04:33:46 UTC]

hm, I can't reproduce even after downgrading to 2.76.0, so I'm now wondering if that fixes it or not. I'm thinking no.

[Comment 4 Sam James 2023-03-17 04:35:50 UTC]

Ah, it needs -O3.

[Comment 5 Sam James 2023-03-17 04:40:49 UTC]

Reported upstream at https://gitlab.gnome.org/GNOME/libsoup/-/issues/340.

[Comment 6 Sam James 2023-03-17 18:33:43 UTC]

This is fixed in the just-tagged 3.4.0.

[Comment 7 Sam James 2023-03-19 00:20:38 UTC]

(In reply to Sam James from comment #6)
> This is fixed in the just-tagged 3.4.0.

Now in tree.