Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 90144 - Patch: a couple of fixes/updates for utf-8.xml
Summary: Patch: a couple of fixes/updates for utf-8.xml
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs-user
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Benny Chuang (RETIRED)
URL: http://gentoo.org/doc/en/utf-8.xml
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-23 10:17 UTC by Tom Martin (RETIRED)
Modified: 2005-04-24 09:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
utf-8.xml.patch (utf-8.xml.patch,7.35 KB, patch)
2005-04-23 10:19 UTC, Tom Martin (RETIRED)
Details | Diff
utf-8.xml.patch (utf-8.xml.patch,10.29 KB, patch)
2005-04-23 14:16 UTC, Tom Martin (RETIRED)
Details | Diff
utf-8.xml.2.patch (utf-8.xml.patch,1.53 KB, patch)
2005-04-24 01:20 UTC, Tom Martin (RETIRED)
Details | Diff
utf-8.xml.2.patch (utf-8.xml.2.patch,4.21 KB, patch)
2005-04-24 06:52 UTC, Tom Martin (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Martin (RETIRED) gentoo-dev 2005-04-23 10:17:57 UTC
Hi guys,

Attached is a patch for utf-8.xml with a number of changes, the most important of which is the dropping of KEYMAP="-u uk" for KEYMAP="uk". It seems -u uk threw a warning at bootup and caused more trouble than it fixed. Till I can figure what's going on with it, I'd like it to be changed back to just "uk". Users couldn't input Unicode on the console before anyway, so it doesn't really make much difference.

Also, Jani Averbach <jaa@jaa.iki.fi> mailed me, suggesting I mention the performance hit with perl and grep and Unicode, and also the bug where tr cannot translate three-byte unicode characters into two-byte unicode characters. 

There's also a few grey areas which I wanted to clarify -- they're fixed up in the patch as well.

Thanks,
Tom
Comment 1 Tom Martin (RETIRED) gentoo-dev 2005-04-23 10:19:21 UTC
Created attachment 57024 [details, diff]
utf-8.xml.patch
Comment 2 Tom Martin (RETIRED) gentoo-dev 2005-04-23 14:16:59 UTC
Created attachment 57039 [details, diff]
utf-8.xml.patch

Updated patch. I've rewritten the section on setting the locale so that it is
done globally now. Too many people were finding that their locale was unset
because they were using display managers.
Comment 3 Benny Chuang (RETIRED) gentoo-dev 2005-04-23 14:57:22 UTC
IMO, /etc/locales.build should be somehow mentioned.
Comment 4 Tom Martin (RETIRED) gentoo-dev 2005-04-23 15:13:00 UTC
Benny, it is.
Comment 5 Benny Chuang (RETIRED) gentoo-dev 2005-04-23 20:22:19 UTC
My bad, patched and committed. Thanks :)
Comment 6 Tom Martin (RETIRED) gentoo-dev 2005-04-24 01:20:27 UTC
Created attachment 57074 [details, diff]
utf-8.xml.2.patch

Just noticed a couple of things that I forgot:

* Schauffer's is a blatant spelling mistake for scharfes. I'm sure I meant to
change that.

* The indentation on the source /etc/profile <pre> line was wrong, fixed.

* Changed locale name endings to be consistent throughout the file.

This patch is to the new version in CVS.

Sorry for the continuing hassle :(

Tom
Comment 7 Xavier Neys (RETIRED) gentoo-dev 2005-04-24 03:22:04 UTC
Attachment #57039 [details, diff] was not against current version. It reverted changes and introduced back spelling mistakes.
Comment 8 Benny Chuang (RETIRED) gentoo-dev 2005-04-24 03:44:31 UTC
I apologize for the hassel. Tom has agreed to fix the the doc.
Comment 9 Tom Martin (RETIRED) gentoo-dev 2005-04-24 06:52:53 UTC
Created attachment 57093 [details, diff]
utf-8.xml.2.patch

Okay, this should be okay.

Sorry about the trouble, and thanks for bearing with me

Tom
Comment 10 Benny Chuang (RETIRED) gentoo-dev 2005-04-24 07:12:58 UTC
verified and committed. Thanks and sorry guys
Comment 11 Flammie Pirinen (RETIRED) gentoo-dev 2005-04-24 09:26:37 UTC
Humph. I'd appreciate if verifying meant that someone has actually tested and verified stuff and not that no-one has even looked at the patch but commits it anyway ;-)

It still talks about setting variable named LOCALE which has no meaning whatsoever.

AltGr+4 does not produce euro on most of european keyboards according to what keymap files say, instead it is either AltGr+5 or AltGr+e.

And version is still not bumped correctly.

Besides LC_ALL and LANG are mostly the same variable with different precedence.

See also bug 90208 which was reported while you were messing the doc up.