Bug 90141 – There is an encapsulation violation in the arch template selection code.

• Status: RESOLVED FIXED
• Product: Gentoo Release Media

[Description Christopher Hotchkiss 2005-04-23 10:04:35 UTC]

Starting on line 124 of GLIClientController.py the arch template code attempts to set the correct template. However instead of using the get_architecture_template() function, the private variable is used instead.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




patch to fix the problem:
--- GLIClientController.py      2005-04-21 22:25:30.000000000 +0000
+++ 2.tmp.py    2005-04-23 16:58:34.000000000 +0000
@@ -121,12 +121,12 @@
                                'ppc64':        'ppc64ArchitectureTemplate'
                        }

-               if self._configuration._architecture_template not in
templates.keys():
-                       self.addNotification(GLINotification("exception",
UnsupportedArchitectureError('fatal', 'run',
self._configuration._architecture_template + ' is not supported by the Gentoo
Linux Installer!')))
+               if self._configuration.get_architecture_template() not in
templates.keys():
+                       self.addNotification(GLINotification("exception",
UnsupportedArchitectureError('fatal', 'run',
self._configuration.get_architecture_template() + ' is not supported by the
Gentoo Linux Installer!')))

                try:
-                       template = __import__(TEMPLATE_DIR + '/' +
templates[self._configuration._architecture_template])
-                       self._arch_template = getattr(template,
templates[self._configuration._architecture_template])(self._configuration,
self._install_profile, self._pretend)
+                       template = __import__(TEMPLATE_DIR + '/' +
templates[self._configuration.get_architecture_template()])
+                       self._arch_template = getattr(template,
templates[self._configuration.get_architecture_template()])(self._configuration,
self._install_profile, self._pretend)
                except ImportError:
                        self.addNotification(GLINotification("exception",
UnsupportedArchitectureError('fatal', 'run', 'The Gentoo Linux Installer could
not import the install template for this architecture!')))
                except AttributeError:

[Comment 1 Christopher Hotchkiss 2005-04-23 10:06:16 UTC]

Created attachment 57021 [details, diff]
Patch to fix the issue.

[Comment 2 Andrew Gaffney (RETIRED) 2005-04-23 10:10:50 UTC]

Thanks. Fixed in CVS.

[Comment 3 Jeffrey Forman (RETIRED) 2006-03-24 13:46:28 UTC]

Moving to Release Media/Installer.