Bug 90086 – Patch to enable "WMA lossless" decoding in xine-lib-1.0-r3

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Vahur Sinijärv 2005-04-22 17:37:56 UTC]

I made a small patch to enable "WMA Lossless" decoding in xine-lib. Nice sideeffect is that you can play those files in amaroK via xine plugin. I did send it to xine devs too, maybe they'll include it, dont know.
You can include it in current ebuild:
...
	# Fix support for gcc 4
	epatch ${FILESDIR}/${PN}-gcc4.patch

    # Enable WMA Lossless decoding
    epatch ${FILESDIR}/${PN}-wmall.patch
    
    elibtoolize
...


Reproducible: Always
Steps to Reproduce:





Here's the patch: xine-lib-wmall.patch 
 
diff -ur src.orig/libw32dll/w32codec.c src/libw32dll/w32codec.c 
--- src.orig/libw32dll/w32codec.c	2004-12-16 15:59:07.000000000 +0200 
+++ src/libw32dll/w32codec.c	2005-04-23 01:53:07.000000000 +0300 
@@ -1089,6 +1089,12 @@ 
     _x_meta_info_set_utf8(this->stream, XINE_META_INFO_AUDIOCODEC,  
       "Windows Media Audio v3 (win32)"); 
     return "wma9dmod.dll"; 
+  case BUF_AUDIO_WMALL: 
+    this->driver_type = DRIVER_DMO; 
+    this->guid=&wma3_clsid; 
+    _x_meta_info_set_utf8(this->stream, XINE_META_INFO_AUDIOCODEC,  
+      "Windows Media Audio Lossless (win32)"); 
+    return "wma9dmod.dll"; 
   case BUF_AUDIO_WMAV: 
     this->driver_type = DRIVER_DMO; 
     this->guid=&wmav_clsid; 
@@ -1703,6 +1709,7 @@ 
   BUF_AUDIO_WMAV1, BUF_AUDIO_WMAV2, BUF_AUDIO_WMAV3, BUF_AUDIO_MSADPCM,  
   BUF_AUDIO_MSIMAADPCM, BUF_AUDIO_MSGSM, BUF_AUDIO_IMC, BUF_AUDIO_LH, 
   BUF_AUDIO_VOXWARE, BUF_AUDIO_ACELPNET, BUF_AUDIO_VIVOG723, BUF_AUDIO_WMAV, 
+  BUF_AUDIO_WMALL, 
   0 
  }; 
  
diff -ur src.orig/xine-engine/buffer.h src/xine-engine/buffer.h 
--- src.orig/xine-engine/buffer.h	2004-12-13 00:01:30.000000000 +0200 
+++ src/xine-engine/buffer.h	2005-04-23 02:07:40.000000000 +0300 
@@ -226,6 +226,7 @@ 
 #define BUF_AUDIO_VMD		0x03320000 
 #define BUF_AUDIO_XAN_DPCM	0x03330000 
 #define BUF_AUDIO_ALAC		0x03340000 
+#define BUF_AUDIO_WMALL		0x03350000 
  
 /* spu buffer types:    */ 
  
diff -ur src.orig/xine-engine/buffer_types.c src/xine-engine/buffer_types.c 
--- src.orig/xine-engine/buffer_types.c	2004-11-30 02:40:59.000000000 +0200 
+++ src/xine-engine/buffer_types.c	2005-04-23 01:43:43.000000000 +0300 
@@ -709,6 +709,13 @@ 
 }, 
 { 
   { 
+    0x163, 0 
+  }, 
+  BUF_AUDIO_WMALL, 
+  "Windows Media Audio Lossless" 
+}, 
+{ 
+  { 
     0xA, 0 
   }, 
   BUF_AUDIO_WMAV,

[Comment 1 Carsten Lohrke (RETIRED) 2005-04-22 17:47:41 UTC]

please don't inline patches, attach as plain text, please

[Comment 2 Vahur Sinijärv 2005-04-22 17:59:44 UTC]

Created attachment 56959 [details, diff]
The patch

Did not find the attach button first time ...

[Comment 3 Diego Elio Pettenò (RETIRED) 2005-04-22 19:15:18 UTC]

I'll take a look at this also if I can't test it directly for now, as I don't have any wma lossless file to test with and also because I need to install xine-lib and xine-ui without X in the x86 environment for using them.

But mainly I think I'll wait to see the feedback from xine-devel mailing list if this is worth adding or not, also because I think a new 1.0.1 release it's not so far and such a feature hasn't a real priority.

[Comment 4 Diego Elio Pettenò (RETIRED) 2005-04-24 12:46:51 UTC]

Applied in -r4 revision, as there were other fixes to apply.