Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 90048 - faad2-2.0-r5 doesn't compile with gcc4
Summary: faad2-2.0-r5 doesn't compile with gcc4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Low normal (vote)
Assignee: foser (RETIRED)
URL:
Whiteboard:
Keywords:
: 114823 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-22 10:01 UTC by Håvard Wall
Modified: 2005-12-08 00:30 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix compile with gcc4 (faad2-2.0-gcc4.patch,273 bytes, patch)
2005-04-22 10:03 UTC, Håvard Wall
Details | Diff
Fix compile with gcc4 (faad.patch,510 bytes, patch)
2005-04-25 10:33 UTC, Håvard Wall
Details | Diff
Also get rid of warnings (gcc4-warnings-and-errors.patch,11.79 KB, patch)
2005-05-29 17:28 UTC, Harald van Dijk (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Håvard Wall 2005-04-22 10:01:01 UTC
The compiler says it all.

Reproducible: Always
Steps to Reproduce:
1. emerge --oneshot faad2-2.0-r5

Actual Results:  
mp4ff.c:91: error: static declaration of 'mp4ff_track_add' follows non-static
declaration
mp4ffint.h:304: error: previous declaration of 'mp4ff_track_add' was here



Gentoo Base System version 1.6.11
Portage 2.0.51.19 (default-linux/x86/2005.0, gcc-4.0.0, glibc-2.3.4.20050125-r1,
2.6.11-gentoo-r5 i686)
=================================================================
System uname: 2.6.11-gentoo-r5 i686 AMD Athlon(tm) XP 2500+
Python:              dev-lang/python-2.3.5 [2.3.5 (#1, Apr  4 2005, 17:41:39)]
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled]
ccache version 2.4 [enabled]
dev-lang/python:     2.3.5
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.5
sys-devel/binutils:  2.15.92.0.2-r8
sys-devel/libtool:   1.5.14
virtual/os-headers:  2.6.11
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer -mmmx -msse -m3dnow
-mfpmath=sse -ffast-math"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer -mmmx -msse -m3dnow
-mfpmath=sse -ffast-math"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig ccache distcc distlocks sandbox sfperms strict
userpriv usersandbox"
GENTOO_MIRRORS="ftp://ftp.uninett.no/pub/linux/Gentoo
ftp://mirror.pudas.net/gentoo ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo
ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo
http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.no.gentoo.org/gentoo-portage"
USE="x86 16bit 3dnow 3dnowex 3dnowext X acpi ada alsa apache2 apm arts avi
bash-completion berkdb bitmap-fonts bzip2 bzlib c++ ccache cdr cdrom cgi clamav
cpdflib cracklib crypt cscope css csv cups curl dbcp dhcp dict directfb
divx4linux doc dpms dv emacs emboss encode examples fam fb fbcon fbdev festival
ffmpeg fftw firefox flac flash font-server foomaticdb fortran freetts freetype
ftp gcj gd gdbm gif gimp gimpprint glade glgd glut gmail gmp gphoto2 gpm gs
gstreamer hal haskell html http httpd imagemagick imlib immqt ipv6 java jikes
jpeg jpeg2k junit kde kdeenablefinal kdepim kdexdeltas libg++ libwww
logitech-mouse logrotate lzo lzw lzw-tiff mad mbrola mikmod mixer mjpeg mmx
mmxext motif mp3 mpeg mpeg4 mpi mplayer multislot multitarget ncurses nls nptl
nvidia ogg oggvorbis opengl oss pam pascal pdf pdfkit pdflib perforce perl php
pic pie png postgres python qt quicktime rar readline real ruby scanner sdl sms
sockets source speech speex spell sql sqlite3 sse ssl subversion svg svga svgz
tcltk tcpd tidy tiff truetype truetype-fonts type1 type1-fonts usb userlocales
utf8 vorbis win32codecs xanim xine xml2 xmms xpm xprint xrandr xscreensaver xsl
xslt xv xvid zlib video_cards_nvidia"
Unset:  ASFLAGS, CBUILD, CTARGET, LANG, LC_ALL, LDFLAGS, LINGUAS
Comment 1 Håvard Wall 2005-04-22 10:03:12 UTC
Created attachment 56932 [details, diff]
Fix compile with gcc4

Remove the conflicting static keyword.
Comment 2 foser (RETIRED) gentoo-dev 2005-04-24 10:03:24 UTC
Are you sure is it the correct fix to remove the static keyword instead of adding it?
Comment 3 Håvard Wall 2005-04-25 10:32:45 UTC
Well, actually no. I don't think it matters actually. It seems like the function is only used in one compile unit, is not in the public API, and doesn't get exported anyway.

I choose to remove the keyword to be consistent with the other functions with the same prefix.

Anyway, It seems to work just as well when adding the keyword instead.
Comment 4 Håvard Wall 2005-04-25 10:33:54 UTC
Created attachment 57198 [details, diff]
Fix compile with gcc4

Add the static keyword instead of removing it.
Comment 5 Kristiaan Lenaerts 2005-05-01 14:15:42 UTC
This patch works for me, I'm working my way trough all the failures I've had when recompiling my system with gcc 4.0.0, and this is a typical problem.
Comment 6 Andreas Simon 2005-05-28 08:23:10 UTC
I can confirm that the patch works. 
Comment 7 Mark Loeser (RETIRED) gentoo-dev 2005-05-28 15:02:13 UTC
foser, I can confirm this works as well.  I've had the patch in my overlay for
awhile now and no one has complained to me either.
Comment 8 Harald van Dijk (RETIRED) gentoo-dev 2005-05-29 17:28:01 UTC
Created attachment 60133 [details, diff]
Also get rid of warnings

Hi, I decided to also get rid of a bunch of legitimate warnings gcc 4 throws at
the same time. (Some may have also been given with older gcc versions.)
Comment 9 foser (RETIRED) gentoo-dev 2005-06-03 14:11:03 UTC
Sorry I took so long, I added the last patch to 2.0-r7 , thanks for the works.
Comment 10 Jakub Moc (RETIRED) gentoo-dev 2005-12-08 00:30:29 UTC
*** Bug 114823 has been marked as a duplicate of this bug. ***