Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 90025 - linux-mod should IUSE="pcmcia"
Summary: linux-mod should IUSE="pcmcia"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2005-04-22 03:01 UTC by Georgi Georgiev
Modified: 2005-05-13 00:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgi Georgiev 2005-04-22 03:01:05 UTC
Currently, linux-mod.eclass has the following:

DEPEND="virtual/linux-sources
        sys-apps/sed
        virtual/modutils
        pcmcia? ( sys-apps/pcmcia-cs )"

In my opinion, this means that it should also contain the line

IUSE="pcmcia".

I had a hell of a time figuring out why some packages wanted to install pcmcia-cs (which was only giving me errors anyway).
Comment 1 John Mylchreest (RETIRED) gentoo-dev 2005-04-22 12:11:48 UTC
Agreed. Good spot. Is now comitted into the tree.
Comment 2 Henrik Brix Andersen 2005-04-25 10:31:40 UTC
The current solution makes _all_ linux-mod derived ebuilds have USE="pcmcia" even though the ebuild doesn't have anything to use the pcmcia flag for.

I think the correct solution would be to enforce ebuilds, that use the pcmcia USE flag to have IUSE="pcmcia".
Comment 3 John Mylchreest (RETIRED) gentoo-dev 2005-04-25 11:46:31 UTC
hmm, apparently so :)
After looking at the list there is only:

hostap-driver
linux-wlan-ng
orinoco

which inherits pcmcia (originally). brix, since this is your area can I leave you with these?
Comment 4 Henrik Brix Andersen 2005-05-12 13:10:01 UTC
I've ensured that all of the above mentioned ebuilds include IUSE=pcmcia - and I've removed the IUSE=pcmcia from linux-mod.eclass (again).

Closing as FIXED.
Comment 5 Georgi Georgiev 2005-05-12 19:41:16 UTC
Hm, so if I install for example media-tv/rivatv, or any of the other 78 packages that inherit linux-mod, I'll have no way of figuring out why sys-apps/pcmcia is being pulled as a dependency?

Re: Comment #2
> The current solution makes _all_ linux-mod derived ebuilds have
> USE="pcmcia" even though the ebuild doesn't have anything to use the
> pcmcia flag for.
That's not true. It has *everything* to do with the ebuild using the pcmcia flag to pull a dependency.
Comment 6 Stefan Schweizer (RETIRED) gentoo-dev 2005-05-12 22:12:25 UTC
Can you please also remove that line then?

        DEPEND="pcmcia? ( sys-apps/pcmcia-cs )"

All pkges that need it should depend on pcmcia-cs anyway ..

Another thing is: SHould we even depend on sys-app/pcmcia-cs now, that pcmciautils can replace it?
Maybe create a virutal?
Comment 7 Henrik Brix Andersen 2005-05-13 00:18:33 UTC
A virtual will be created once pcmciautils enters the tree.