Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89918 - gkrellm-pmu-2.3 does not compile with pbbuttonsd-0.6.9 installed
Summary: gkrellm-pmu-2.3 does not compile with pbbuttonsd-0.6.9 installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High normal
Assignee: PPC Porters
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-21 06:03 UTC by dan
Modified: 2006-01-06 21:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch file to go with patched ebuild (still to come) (2.3-ipc-gentoo.diff,436 bytes, patch)
2005-04-21 07:25 UTC, dan
Details | Diff
change gkrellm-2.3.ebuild to selectively apply the ipc patch (gkrellm-pmu-2.3.ebuild.diff,904 bytes, patch)
2005-04-21 07:29 UTC, dan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dan 2005-04-21 06:03:50 UTC
The compile breaks on the file gkrellm-pmu.c on line 64. The problem is that the pbblib that comes with pbbuttonsd-0.6.9 changed the interface for the ipc_init() function from:
   int ipc_init (int mode, int reg);
to:
   int ipc_init (char *name, int mode, int reg);

The fix is to patch gkrellm-pmu.c to change line 64 from:
   "if (ipc_init (LIBMODE_CLIENT, 0) == 0) {"
to:
   "if (ipc_init (NULL, LIBMODE_CLIENT, 0) == 0) {"

and then selectively apply this patch depending on the version of pbbuttonsd installed.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 dan 2005-04-21 07:25:30 UTC
Created attachment 56835 [details, diff]
patch file to go with patched ebuild (still to come)

This patch file works with the patched ebuild which I will upload next.
Comment 2 dan 2005-04-21 07:29:50 UTC
Created attachment 56836 [details, diff]
change gkrellm-2.3.ebuild to selectively apply the ipc patch
Comment 3 Lars Weiler (RETIRED) gentoo-dev 2005-12-17 18:18:08 UTC
Just found this bug.  As I don't own a machine with PMU any more, could anybody of you have a look into it?
Comment 4 Luca Barbato gentoo-dev 2005-12-18 06:51:27 UTC
the 2.4 has a fix for it. I pinned the deps and committed the new version in ~ppc, we should mark it stable soon or sooner.
Comment 5 Luca Barbato gentoo-dev 2006-01-06 21:27:39 UTC
Fixed