Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 898010 - kde-plasma/plasma-nm: Optionally build mobile component
Summary: kde-plasma/plasma-nm: Optionally build mobile component
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-02-26 20:51 UTC by Jesús P Rey (Chuso)
Modified: 2023-12-15 21:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús P Rey (Chuso) 2023-02-26 20:51:31 UTC
kde-plasma/plasma-nm has a BUILD_MOBILE CMake flag that would allow building a additional KCMs for mobile devices as required for Plasma Mobile.

I think this CMake flag could be enabled via an USE flag so overwriting ::gentoo's ebuild with a custom ebuild wouldn't be necessary for enabling a feature that is already included and supported upstream.

I've been using such USE flag to optionally enable the mobile KCMs for almost two years now[1] with no issues and I think it should be safe to merge to ::gentoo.

[1] https://github.com/pinetoo/pinetoo/tree/master/kde-plasma/plasma-nm
Comment 1 Andreas Sturmlechner gentoo-dev 2023-02-27 20:12:13 UTC
We don't package Plasma Mobile though. What does it do for us?
Comment 2 Andreas Sturmlechner gentoo-dev 2023-02-28 10:03:01 UTC
I'm btw aware of the build option though it isn't even advertised by upstream, see my MR there.
Comment 3 Jesús P Rey (Chuso) 2023-03-05 20:13:45 UTC
> We don't package Plasma Mobile though.

Does it mean it will never be packaged by Gentoo?
I thought that allowing the choice via USE flags for packages that are currently in ::gentoo but unconditionally disable mobile components could be a good thing or even one step towards getting Plasma Mobile supported.

> What does it do for us?

Well, I guess it does what most of the USE flags do — giving users the ability to choose which features are enabled for a package.

Reversing your question, what damage could adding this USE flag do that could cause someone to oppose its addition?
There are ways in which you can break your system with wrong USE flags, but I don't see any danger in this one.

On a more personal note, I am running Gentoo on the PinePhone and for every new release of kde-plasma/plasma-nm in ::gentoo, I have to copy and modify it just to be able to enable this component.
I think it's an unnecessary hassle for such a small thing and I thought contributing the change to ::gentoo after having tested it for two years would be a good thing.

However, from your MR mentioned, it seems you were already tracking this build option, so maybe there are already other plans to support it?
Comment 4 Andreas Sturmlechner gentoo-dev 2023-03-05 20:47:35 UTC
Someone's got to package and support it. So far no one volunteered.

Until then you've got to sell it to me - our job is not to provide each and every knob a build system has as a USE flag. So, what would it do for the Plasma desktop user right now?
Comment 5 Andreas Sturmlechner gentoo-dev 2023-12-15 21:21:17 UTC
mobile component was moved where it should have been from the beginning:

https://invent.kde.org/plasma/plasma-nm/-/commit/37df00779c6bd3d5aafda1f55cef73a31108e2c8

plasma-mobile:
https://invent.kde.org/plasma/plasma-mobile/-/merge_requests/320