Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89758 - CUPS should optionally use tiff
Summary: CUPS should optionally use tiff
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Printing (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Printing Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-20 00:13 UTC by Ginsu
Modified: 2005-09-15 17:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to make tiff optional (tiff.patch,688 bytes, patch)
2005-05-10 18:29 UTC, Ginsu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ginsu 2005-04-20 00:13:32 UTC
CUPS is the only ebuild that I have seen to require tiff and I have been building cups for years without it just fine.  I suggest using the tiff use flag to make it optional.

Reproducible: Always
Steps to Reproduce:
Comment 1 Chris Smith 2005-05-10 07:54:50 UTC
From the cups docs:
"For the image file filters and PostScript RIP, you'll need the JPEG, PNG, TIFF, and ZLIB libraries. CUPS will build without these, but with significantly reduced functionality."

Seems to be a strong recommendation for having these installed. Also "tiff" is not a configure option. Probably a case where best practice may be to manage an overlay ebuild and remove the tiff dependency.
Comment 2 Heinrich Wendel (RETIRED) gentoo-dev 2005-05-10 08:59:30 UTC
since there is no configure option to en/disable tiff support and unless you come up with a patch for it, i'll mark this one as wontfix
Comment 3 Ginsu 2005-05-10 18:29:51 UTC
Created attachment 58632 [details, diff]
Patch to make tiff optional

I understand it needs to be allowed to be explicitly disabled because of
portage tracking and such.  Here is a patch.
Comment 4 Ginsu 2005-05-10 19:18:30 UTC
attached was a patch, reopening
Comment 5 Chris Smith 2005-05-11 09:25:24 UTC
Correct me if I'm wrong but I believe cups will build, as the docs state, just fine without the JPEG, PNG, TIFF, and ZLIB libraries.
Instead of patching the cups source why not just remove the media-libs/tiff dependency in the ebuild itself? Then unmerge media-libs/tiff, if necessary, and remerge cups.

Again this does seem to be a case where you should just manage your own overlay ebuild and/or pacthset.

If the devs want to change it, then it only makes sense that a use flag for all 4 libraries is incorporated, not just for TIFF support. And probably best to default to using them unless they are specifically not requested.
Comment 6 Ginsu 2005-05-11 17:10:52 UTC
If cups is compiled against any libraries, they HAVE to be in the deps section.  If tiff is present it'll link against it, but portage won't know it depends on it, hence the need for DEPEND.  Having all 4 use flags IMO would be a little too much.  jpeg, zlib, png are pretty common that you would want support for them but tiff is pretty obscure IMO.
Comment 7 Chris Smith 2005-05-11 17:35:55 UTC
This is something to approach the CUPS developers with at cups.org. Ask them to include the patch with a configure option, then the Gentoo devs wont have to maintain a "franken-patch" (my meaning is basically a one off that wont be found in other distros and will change the expected documented behavior of the product) for every new cups release.

As for tiff, it's quite popular. I can't imagine a working printing system not supporting it.
Comment 8 Luis Medinas (RETIRED) gentoo-dev 2005-08-17 13:12:19 UTC
i don't see any reason to maintain a patch for cups like this. I will mark this
again as WONTFIX.
Thanks all.
Comment 9 Stefan Schweizer (RETIRED) gentoo-dev 2005-08-17 14:02:36 UTC
reopening
Comment 10 Stefan Schweizer (RETIRED) gentoo-dev 2005-08-17 14:05:33 UTC
Resolve bug with correct resolution.

Ron: Please mail the upstream cups developers with this patch and get them to
apply it. 
Can you please notify us when the patch is applied in the cups cvs?
It is just too much work for us to maintain this patch in portage and carry it
along without having upstream approval, I hope you understand ..
Comment 11 Ginsu 2005-09-15 17:04:36 UTC
The patch has made it in to the CUPS svn.

http://www.cups.org/str.php?L1248