Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 895740 - www-client/chromium-109.0.5414.74-r1 : wrong dependencies
Summary: www-client/chromium-109.0.5414.74-r1 : wrong dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2023-02-21 17:11 UTC by Igor Franchuk
Modified: 2023-09-28 05:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Franchuk 2023-02-21 17:11:44 UTC
1. dependency on dev-util/gn should be >=  0.1943, with gn-0.1807 ebuild fails with 

   "GN assignment has no effect / variable unused before it went out of scope" 

2. >=app-accessibility/at-spi2-core-2.46.0:2  is pulling in >=dev-libs/glib-2.67.4

   I suggest to revision the use of atk, Accessibility Toolkit is useless for the majority of users yet it pulls in a problematic at-spi2 and rises glib version. 

chromium has the flag use_atk, defined in 

/chromium-109.0.5414.74/build/config/ui.gni

as 

use_atk = use_glib && current_toolchain == default_toolchain

if we set use_atk as

use_atk = false 

then chromium doesn't require any ATK library to compile. I think that should be the default and use_atk should be by default set to false and the mandatory dependency on 

		>=app-accessibility/at-spi2-core-2.46.0:2

dropped.

Or at least the use flag atk should be added for chromium 



Reproducible: Always
Comment 1 René Kjellerup 2023-03-23 01:56:49 UTC
updated gn from dev-util/gn-0.1807 to dev-util/gn-0.2049
and chromium-109 would build after that

I can confirm that I got this error too:
"GN assignment has no effect / variable unused before it went out of scope"

while building www-client/chromium-109.0.5414.74-r1 with dev-util/gn-0.1807
Comment 2 Matt Jolly gentoo-dev 2023-09-24 06:26:48 UTC
Thanks for the update.

The `gn` dependency has been updated in the latest chromium ebuilds.

I'll have a think about adding and `accessibility` USE to chromium to take care of the at-spi dependency.
Comment 3 Matt Jolly gentoo-dev 2023-09-24 07:31:14 UTC
I did a bit of work and even linked this bug in a PR, but at the end of the day:

> if we set use_atk as
>
> use_atk = false

Means yet another deviation from upstream in a completely unsupported manner. It'd likely be a simple 'sed' and I did the rest of the ebuild plumbing for it but I don't want to add the additional maintenance and testing overhead to our ebuilds, sorry!
Comment 4 Igor Franchuk 2023-09-28 05:08:16 UTC
(In reply to Matt Jolly from comment #2)
> Thanks for the update.
> 
> The `gn` dependency has been updated in the latest chromium ebuilds.
> 
> I'll have a think about adding and `accessibility` USE to chromium to take
> care of the at-spi dependency.

That would be safe I've been using use_atk = false for quite a while and it works with all the chromium releases. A very useful option to remove accessibility dependency 

>=app-accessibility/at-spi2-core-2.46.0:2