Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 894994 - net-libs/libssh2: compilation warning: no return statement in function returning non-void
Summary: net-libs/libssh2: compilation warning: no return statement in function return...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Netmon project
URL: https://github.com/libssh2/libssh2/co...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2023-02-16 21:40 UTC by Jocelyn Mayer
Modified: 2023-02-18 10:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch proposal to fix the missing return value. (libssh2-1.10.0-retval.patch,344 bytes, patch)
2023-02-16 21:42 UTC, Jocelyn Mayer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Mayer 2023-02-16 21:40:10 UTC 
When compiling libssh2, a warning is emitted:
libssh2-1.10.0/tests/openssh_fixture.c:218:1:
warning: no return statement in function returning non-void [-Wreturn-type]

This should not be critical as it is only in tests subdirectory.
A ticket has opened upstream with a fix proposal

Reproducible: Always

Steps to Reproduce:
1. Build net-libs/libssh2
2. Check the build logs
3.
Actual Results:  
The described warning is emitted

Expected Results:  
No such a warning should be seen
Comment 1 Jocelyn Mayer 2023-02-16 21:42:26 UTC 
Created attachment 851910 [details, diff]
Patch proposal to fix the missing return value.

Note: as I don't know about win32 API, I cannot be sure the fix would be correct in this case; it would for POSIX case.