Bug 893718 – x11-libs/wxGTK: Migrate from net-libs/webkit-gtk:4 to :4.1 if possible

• Status: CONFIRMED
• Product: Gentoo Linux

[Description Matt Turner 2023-02-09 03:04:18 UTC]

We would like to reduce the number of net-libs/webkit-gtk slots.

Please check if it is possible to migrate from net-libs/webkit-gtk:4 to net-libs/webkit-gtk:4.1.

This should be possible (with minor build-system patching, see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea0bb7cd3b47dd02d964a5c27c010eeaea8cc8b1 for example) if net-libs/libsoup:2.4 is not pulled in by the package or any of its dependencies.

[Comment 1 Tee KOBAYASHI 2023-02-09 05:07:14 UTC]

Not that simple. There are references to symbols that are not defined in libsoup-3.0, e.g. SOUP_STATUS_CANCELLED:

https://github.com/wxWidgets/wxWidgets/blob/620e02c568bb7cc410b10ede1b592c20c02dfb9f/src/gtk/webview_webkit2.cpp#L180

[Comment 2 Pacho Ramos 2023-06-20 12:33:06 UTC]

Is there any place upstream to track the progress on this? Last time I searched for it, I couldn't find any bug report or similar :/

[Comment 3 Mart Raudsepp 2023-06-20 14:06:04 UTC]

https://github.com/wxWidgets/wxWidgets/pull/23633

[Comment 4 Ulrich Müller 2023-07-22 16:38:31 UTC]

(In reply to Mart Raudsepp from comment #3)
> https://github.com/wxWidgets/wxWidgets/pull/23633

Any chance for backporting this to the 3.2-gtk3 slot?

[Comment 5 mehw 2023-07-23 15:34:07 UTC]

Created attachment 866015 [details, diff]
x11-libs/wxGTK-3.0.5.1-r1.ebuild net-libs/webkit-gtk:4.1 support

Backported from upstream: https://github.com/wxWidgets/wxWidgets/commit/1b8664426603376b68f8ca3c54de97ec630e5940

NOTE: In this backported patch, configure{,.in} only test for webkit2gtk-4.1 presence (tests for webkit2gtk-4.0 are replaced with webkit2gtk-4.1).

/etc/portage/patches/x11-libs/wxGTK-3.0.5.1/wxGTK-3.0.5.1-webkitgtk2-4.1.patch

diff a/wxGTK-3.0.5.1-r1.ebuild b/wxGTK-3.0.5.1-r1.ebuild 
51c51
<               webkit? ( net-libs/webkit-gtk:4 )
---
>               webkit? ( net-libs/webkit-gtk:4.1 )

[Comment 6 mehw 2023-07-23 15:37:18 UTC]

Created attachment 866016 [details, diff]
x11-libs/wxGTK-3.2.2.1-r2.ebuild net-libs/webkit-gtk:4.1 support

Backported from upstream: https://github.com/wxWidgets/wxWidgets/commit/1b8664426603376b68f8ca3c54de97ec630e5940

NOTE: In this backported patch, configure{,.in} only test for webkit2gtk-4.1 presence (tests for webkit2gtk-4.0 are replaced with webkit2gtk-4.1).

/etc/portage/patches/x11-libs/wxGTK-3.2.2.1/wxGTK-3.2.2.1-webkitgtk2-4.1.patch

diff a/wxGTK-3.2.2.1-r2.ebuild b/wxGTK-3.2.2.1-r2.ebuild 
51c51
<               webkit? ( net-libs/webkit-gtk:4 )
---
>               webkit? ( net-libs/webkit-gtk:4.1 )

[Comment 7 Pacho Ramos 2023-11-16 14:36:26 UTC]

It seems versions newer than 3.2.3 should fix this as they include the needed patch:
https://src.fedoraproject.org/rpms/wxGTK/c/065f1ec8d32d1d1fade9d8dc25e4e930432504c7?branch=rawhide

[Comment 8 Pacho Ramos 2024-07-18 19:18:01 UTC]

(In reply to Pacho Ramos from comment #7)
> It seems versions newer than 3.2.3 should fix this as they include the
> needed patch:
> https://src.fedoraproject.org/rpms/wxGTK/c/
> 065f1ec8d32d1d1fade9d8dc25e4e930432504c7?branch=rawhide

Indeed, it seems we could use :4.1 for the latest version
https://src.fedoraproject.org/rpms/wxGTK/blob/rawhide/f/wxGTK.spec#_25

[Comment 9 Michael Orlitzky 2024-10-02 13:04:22 UTC]

So now the problem is reduced to stabilizing wxGTK-3.2.5 and then eliminating all consumers of older slots D: