Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89181 - Moving arch-specific stuff out of make.globals
Summary: Moving arch-specific stuff out of make.globals
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Configuration (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-15 07:13 UTC by Jason Stubbs (RETIRED)
Modified: 2005-04-22 20:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Stubbs (RETIRED) gentoo-dev 2005-04-15 07:13:05 UTC
Trying to get everything not portage configuration specific out of the make.globals file. Arch specific differences are below. Please copy (modifying if you wish as that's the point) these into the relevant profiles.


# alpha
CHOST="alpha-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"
FEATURES="-sandbox"


# amd64
CHOST="x86_64-pc-linux-gnu"
CFLAGS="-march=x86-64 -O2 -pipe"
CXXFLAGS="${CFLAGS}"


# arm
CHOST="arm-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=strongarm110 -pipe"
CXXFLAGS="${CFLAGS}"


# hppa
CHOST="hppa-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="-O1 -pipe"
FEATURES="-sandbox"


# ia64
CHOST="ia64-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"


# mac
CHOST="ppc-darwin"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"
FETCHCOMMAND="/usr/bin/ftp -o \${DISTDIR}/\${FILE} \${URI}"
RESUMECOMMAND="/usr/bin/ftp -R -o \${DISTDIR}/${FILE} \${URI}"
FEATURES="-sandbox"


# mips
CHOST="mips-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"
FEATURES="-sandbox"


# ppc
CHOST="powerpc-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"
FEATURES="-sandbox"


# ppc64
CHOST="powerpc64-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"
FEATURES="-sandbox"


# s390
CHOST="s390-ibm-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"


# sparc
CHOST="sparc-unknown-linux-gnu"
CFLAGS="-O2 -pipe"
CXXFLAGS="${CFLAGS}"
FEATURES="-sandbox"


# x86-fbsd
CHOST="i686-unknown-freebsd5.3"
FETCHCOMMAND='/usr/bin/fetch -o "${DISTDIR}/${FILE}" "${URI}"'
RESUMECOMMAND='/usr/bin/fetch -r -o "${DISTDIR}/${FILE}" "${URI}"'
CFLAGS="-O2 -mtune=i686 -pipe"
CXXFLAGS="${CFLAGS}"
FEATURES="-sandbox"


# x86
CHOST="i686-pc-linux-gnu"
CFLAGS="-O2 -mcpu=i686 -pipe"
CXXFLAGS="${CFLAGS}"
Comment 1 SpanKY gentoo-dev 2005-04-15 07:19:54 UTC
unwritten policy before was to not specify CFLAGS/CXXFLAGS/CHOST in profiles

i guess that's changed now huh :p
Comment 2 Jason Stubbs (RETIRED) gentoo-dev 2005-04-15 07:25:39 UTC
Any logical reason for it? Anybody still supporting the unwritten policy? Seems to me that it's against the policy of only commiting things one can test. ;)
Comment 3 Simon Stelling (RETIRED) gentoo-dev 2005-04-15 07:41:38 UTC
amd64 done, i can't see a reason for not sticking cflags into make.defaults. the hardened/amd64-profile still needs to be done as i don't know what hardened currently uses as standard flags
Comment 4 Jason Stubbs (RETIRED) gentoo-dev 2005-04-15 07:51:06 UTC
Ah, yes. There is one logical reason - recently. 2.0.50 tries to treat *everything* as incremental in make.defaults. Thus CFLAGS="-O2" removes O2 from previous definitions.. Luckily 2.0.50 breaks with the stacked profiles anyway. :)
Comment 5 solar (RETIRED) gentoo-dev 2005-04-15 08:44:26 UTC
So whats the deal? 
Do I need to add CFLAGS/CHOST/CXXFLAGS etc for all the embedded and hardened profiles?
If so should they not be set to i386 tuple vs the i686 tuple for the case of x86?
Comment 6 Jason Stubbs (RETIRED) gentoo-dev 2005-04-15 08:56:14 UTC
i386 would be safer. These are the settings that are in make.globals for each respective keyword. I'm not saying they're sane - just what is. I believe every stage's make.conf also has definitions so these would rarely be used. Look at them as a last resort fallback. They need to go at whatever the deepest level is that first segregates the architecture.
Comment 7 Hasan Khalil (RETIRED) gentoo-dev 2005-04-15 09:37:27 UTC
For default-darwin/macos, everything should already be set, with some differences to what is put below:

{FETCH,RESUME}COMMAND references 'curl' instead of 'ftp' (this is what was already there)
CHOST=powerpc-apple-darwin (again, what was already there)

As a note, the default-darwin profile does not define CHOST. IMO it shouldn't.

Please advise if any of that is wrong. If nothing has been declared 'wrong' in 24 hours, I'll remove osx@gentoo.org from the CC list of this bug.
Comment 8 SpanKY gentoo-dev 2005-04-15 10:23:00 UTC
yes, the unwritten policy was ... erm written ... when 2.0.50 was our stable and every variable was being stacked

so putting CHOST into profiles was a Bad Thing :)

current 2.0.51 stable seems to not do this so it's fine for me if we move this stuff into cascading profiles
Comment 9 solar (RETIRED) gentoo-dev 2005-04-15 10:52:27 UTC
hardened profiles are done for for all arches.

SpanKY you got the uclibc ones covered?
Comment 10 SpanKY gentoo-dev 2005-04-15 11:00:06 UTC
yes, i'll queue the uclibc ones for commit
Comment 11 Stephen Bennett (RETIRED) gentoo-dev 2005-04-15 11:10:48 UTC
BSD updates in cvs.
Comment 12 Luca Barbato gentoo-dev 2005-04-15 12:07:19 UTC
ppc updated
Comment 13 Gustavo Zacarias (RETIRED) gentoo-dev 2005-04-15 12:12:49 UTC
sparc done.
Comment 14 SpanKY gentoo-dev 2005-04-16 01:20:45 UTC
ok, alpha/arm/hppa/ia64/s390/x86 should be all set for default-linux and uclibc trees
Comment 15 Chris PeBenito (RETIRED) gentoo-dev 2005-04-16 07:53:57 UTC
selinux profiles fixed
Comment 16 Jason Stubbs (RETIRED) gentoo-dev 2005-04-18 07:48:36 UTC
Just missing mips? Most of the mips profiles all seem to have CFLAGS and CXXFLAGS, but not all have CHOST. This a problem?
Comment 17 Jason Stubbs (RETIRED) gentoo-dev 2005-04-22 20:28:45 UTC
I'll assume that it's not a problem as the default-darwin profiles aren't including it either.