Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891411 - net-nds/openldap-2.4.58-r2: build with large file support
Summary: net-nds/openldap-2.4.58-r2: build with large file support
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo LDAP project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lfs-tracker
  Show dependency tree
 
Reported: 2023-01-19 18:52 UTC by Allen Webb
Modified: 2023-09-06 05:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Webb 2023-01-19 18:52:09 UTC
openldap is missing the lfs flags. I sent this upstream but it hasn't shown up in the archives yet:
https://lists.openldap.org/hyperkitty/list/openldap-bugs@openldap.org/2023/1/\

I am going to try adding append-lfs-flags from flag-o-matic.

Here is the built log output:
openldap-2.4.58-r2: 18:33:38.552  * QA Notice: The following files were not built with LFS support:
openldap-2.4.58-r2: 18:33:38.565  *   Please see https://issuetracker.google.com/201531268 for details.
openldap-2.4.58-r2: 18:33:38.581  * fopen,fstat /usr/bin/ldapdelete
openldap-2.4.58-r2: 18:33:38.584  * fopen,fstat /usr/bin/ldapmodrdn
openldap-2.4.58-r2: 18:33:38.588  * fopen,fstat /usr/bin/ldapwhoami
openldap-2.4.58-r2: 18:33:38.591  * fopen,fstat /usr/bin/ldapmodify
openldap-2.4.58-r2: 18:33:38.595  * fopen,mkstemp,fstat /usr/bin/ldapsearch
openldap-2.4.58-r2: 18:33:38.599  * fopen,fstat /usr/bin/ldappasswd
openldap-2.4.58-r2: 18:33:38.602  * fopen,fstat /usr/bin/ldapexop
openldap-2.4.58-r2: 18:33:38.606  * fopen,fstat /usr/bin/ldapcompare
openldap-2.4.58-r2: 18:33:38.609  * fopen /usr/lib/libldap-2.4.so.2.11.6
openldap-2.4.58-r2: 18:33:38.613  * fopen /usr/lib/libldap_r-2.4.so.2.11.6
openldap-2.4.58-r2: 18:33:38.627  * Full build files:
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/ldapdelete.o
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapdelete
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapmodrdn
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapwhoami
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapmodify
openldap-2.4.58-r2: fopen,mkstemp,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapsearch
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldappasswd
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapexop
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/.libs/ldapcompare
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/ldapmodrdn.o  
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/ldapmodify.o
openldap-2.4.58-r2: fopen,mkstemp /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/clients/tools/ldapsearch.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/liblutil/getpass.o
openldap-2.4.58-r2: lockf /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/liblutil/lockf.o
openldap-2.4.58-r2: fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/liblutil/passfile.o
openldap-2.4.58-r2: __open_2 /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/liblutil/detach.o
openldap-2.4.58-r2: __open_2 /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/liblutil/sha1.o
openldap-2.4.58-r2: open,fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/.libs/ltest
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/.libs/ldif.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/.libs/fetch.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/.libs/libldap_r-2.4.so.2.11.6T
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/.libs/init.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/.libs/libldap_r-2.4.so.2.11.6
openldap-2.4.58-r2: open,fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap_r/test.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/librewrite/rewrite.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/librewrite/.libs/rewrite
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/librewrite/xmap.o 
openldap-2.4.58-r2: open,fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/.libs/ltest
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/.libs/ldif.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/.libs/libldap-2.4.so.2.11.6T
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/.libs/fetch.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/.libs/init.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/.libs/libldap-2.4.so.2.11.6
openldap-2.4.58-r2: open,fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/libraries/libldap/test.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/tests/progs/.libs/slapd-addel
openldap-2.4.58-r2: readdir,fopen,fstat /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/tests/progs/.libs/slapd-tester
openldap-2.4.58-r2: readdir,fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/tests/progs/slapd-tester.o
openldap-2.4.58-r2: fopen /build/arm-generic/tmp/portage/net-nds/openldap-2.4.58-r2/work/openldap-2.4.58-.arm/tests/progs/slapd-addel.o

Reproducible: Always
Comment 1 Allen Webb 2023-01-19 19:06:32 UTC
This worked for me.


diff --git a/net-nds/openldap/openldap-2.4.58-r2.ebuild b/net-nds/openldap/openldap-2.4.58-r2.ebuild
index 22200554a..c19d6ed33 100644
--- a/net-nds/openldap/openldap-2.4.58-r2.ebuild
+++ b/net-nds/openldap/openldap-2.4.58-r2.ebuild
@@ -413,6 +413,8 @@ multilib_src_configure() {
 
        use debug && myconf+=( $(use_enable debug) )
 
+       append-lfs-flags
+
        # ICU exists only in the configure, nowhere in the codebase, bug #510858
        export ac_cv_header_unicode_utypes_h=no ol_cv_lib_icu=no
Comment 2 Allen Webb 2023-01-19 22:42:04 UTC
The upstream bug is: https://bugs.openldap.org/show_bug.cgi?id=9987
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-02-12 06:44:01 UTC
Can you verify it doesn't break ABI wrt libldap*? Thanks.
Comment 4 Allen Webb 2023-02-13 16:18:57 UTC
Checking for obvious usage of off_t in exported functions yields nothing in header files except `include/portable.hin` which looks interesting:
```
> grep -rHni 'off_t'
libraries/liblmdb/mdb.c:1309:   off_t           me_size;                /**< current file size */
libraries/liblmdb/mdb.c:3843:   off_t off;
libraries/liblmdb/mdb.c:4775:   off_t size, rsize;
servers/slapd/logging.c:62:static off_t logfile_fsize;
servers/slapd/overlays/homedir.c:1428:          off_t pos = ftello( tp->file );
servers/slapd/overlays/homedir.c:1488:          off_t pos = ftello( tp.file );
configure:22994:ac_fn_c_check_type "$LINENO" "off_t" "ac_cv_type_off_t" "$ac_includes_default"
configure:22995:if test "x$ac_cv_type_off_t" = xyes; then :
configure:23000:#define off_t long
configure.ac:2208:AC_CHECK_TYPE(off_t, long)
include/portable.hin:1108:#undef off_t
```

Taking a closer look at portable.hin:
```
/* Define to `long' if <sys/types.h> does not define. */
#undef off_t
```

So it doesn't look like there is something else defined to match off_t I would also need to search for.

Is there something else I should check besides off_t?